Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: override reported OpenSearch version #10586

Merged
merged 1 commit into from
Feb 16, 2022
Merged

docs: override reported OpenSearch version #10586

merged 1 commit into from
Feb 16, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Feb 4, 2022 •
edited
Loading

Fixes: #9414

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 4, 2022
srebhan
srebhan reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @powersj!

@srebhan srebhan self-assigned this Feb 4, 2022
@srebhan srebhan added area/elasticsearch plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 4, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 4, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.17 % for linux amd64 (new size: 140.9 MB, nightly size 137.9 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj mentioned this pull request Feb 4, 2022
Closed
@reimda
Copy link
Contributor

reimda commented Feb 8, 2022

Adding an override seems risky in that someone could put in the override version and forget it and then upgrade, or put in the wrong override version. Then things wouldn't work as intended. I would prefer the approach of detecting whether telegraf is connecting to opensearch or elasticsearch at runtime, then checking the version requirements based on that.

This relies on the ability to detect whether telegraf has connected to one or the other, which I'm not sure how to do.

@powersj
Copy link
Contributor Author

powersj commented Feb 8, 2022 •
edited
Loading

How about we scrap the change and add a comment in the README about enabling compatibility mode in AWS OpenSearch service? Similar to this comment.

@Hipska
Copy link
Contributor

Hipska commented Feb 10, 2022

That sounds good to me.

On the other hand if you still would keep this version checking, I would ask to use semver for the parsing and checking..

@powersj powersj force-pushed the fix/opensearch-support branch from f06fc63 to d7e5226 Compare February 15, 2022 22:37
@powersj powersj changed the title fix: override the reported ElasticSearch version doc: override reported OpenSearch version Feb 15, 2022
@powersj powersj changed the title doc: override reported OpenSearch version docs: override reported OpenSearch version Feb 15, 2022
@powersj
Copy link
Contributor Author

powersj commented Feb 15, 2022

After talking to the team we agreed we prefer documenting how OpenSearch clusters can enable compatibility mode. This is AWS' provided solution for interfacing with existing ElasticSearch clients that need to know which version they are talking to.

@powersj powersj force-pushed the fix/opensearch-support branch from d7e5226 to 476ce5e Compare February 15, 2022 22:39
@powersj powersj force-pushed the fix/opensearch-support branch from 476ce5e to 4970fdc Compare February 15, 2022 22:40
srebhan
srebhan approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better!

@powersj powersj merged commit c1a4138 into influxdata:master Feb 16, 2022
@powersj powersj mentioned this pull request Feb 16, 2022
Closed
3 tasks
powersj added a commit that referenced this pull request Feb 16, 2022
@powersj
docs: override reported OpenSearch version (#10586)
b43b395 
Fixes: #9414
(cherry picked from commit c1a4138)
phemmer added a commit to phemmer/telegraf that referenced this pull request Feb 18, 2022
@phemmer
Merge remote-tracking branch 'origin/master' into postgres
e87744d 
* origin/master: (211 commits)
  feat: update configs (influxdata#10676)
  feat[elastic output]: add elastic pipeline flags (influxdata#10505)
  Update changelog
  fix: ensure folders do not get loaded more than once (influxdata#10551)
  docs: update VMWare doc links (influxdata#10663)
  fix: prometheusremotewrite wrong timestamp unit (influxdata#10547)
  feat: update configs (influxdata#10662)
  fix: add graylog toml tags (influxdata#10660)
  feat: add socks5 proxy support for kafka output plugin (influxdata#8192)
  docs: override reported OpenSearch version (influxdata#10586)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10659)
  fix: bump all go.opentelemetry.io dependencies (influxdata#10647)
  feat: collection offset implementation (influxdata#10545)
  chore: update go to 1.17.7 (influxdata#10658)
  fix: check for nil client before closing in amqp (influxdata#10635)
  fix: timestamp change during execution of json_v2 parser. (influxdata#10657)
  fix: bump github.com/signalfx/golib/v3 from 3.3.38 to 3.3.43 (influxdata#10652)
  fix: bump github.com/aliyun/alibaba-cloud-sdk-go (influxdata#10653)
  fix: incorrect handling of json_v2 timestamp_path (influxdata#10618)
  feat: gather additional stats from memcached (influxdata#10641)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10649)
  fix: Revert deprecation of http_listener_v2 (influxdata#10648)
  fix: bump github.com/denisenkom/go-mssqldb from 0.10.0 to 0.12.0 (influxdata#10503)
  fix: bump github.com/gopcua/opcua from 0.2.3 to 0.3.1 (influxdata#10626)
  fix: use current time as ecs timestamp (influxdata#10636)
  fix: bump github.com/nats-io/nats-server/v2 from 2.6.5 to 2.7.2 (influxdata#10638)
  chore: add -race flag to go tests (influxdata#10629)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10631)
  fix: license doc outdated causing CI failure (influxdata#10630)
  fix: bump k8s.io/client-go from 0.22.2 to 0.23.3 (influxdata#10589)
  feat: Implemented support for reading raw values, added tests and doc (influxdata#6501)
  fix: Improve parser tests by using go-cmp/cmp (influxdata#10497)
  feat(mongodb): add FsTotalSize and FsUsedSize informations (influxdata#10625)
  docs: update quay docs for auth (influxdata#10612)
  chore: allow downgrade of go version in windows script (influxdata#10614)
  chore: update CI go to 1.17.6 (influxdata#10611)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10600)
  fix(inputs.opcua): add more data to error log (influxdata#10465)
  fix: bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.6.0 to 1.13.0 (influxdata#10601)
  refactor: use early return pattern (influxdata#10591)
  ...
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
@powersj @MyaLongmire
docs: override reported OpenSearch version (#10586)
3128461 
Fixes: #9414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@MyaLongmire MyaLongmire MyaLongmire approved these changes

@Hipska Hipska Hipska approved these changes

Assignees

@srebhan srebhan

Labels
area/elasticsearch fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elasticsearch output doesn't work with opensearch
5 participants
@powersj @reimda @Hipska @MyaLongmire @srebhan