Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure folders do not get loaded more than once #10551

Merged
merged 16 commits into from
Feb 16, 2022

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Jan 31, 2022

Required for all PRs:

resolves #10548, resolves #10590, resolves #10603

The root folder was getting appended every time we loaded another folder, making root get appended exponential times. This pr should ensure that each folder only gets loaded once by checking symlinks and if it is a directory.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 31, 2022
@MyaLongmire MyaLongmire marked this pull request as ready for review January 31, 2022 18:59
@Hipska Hipska self-assigned this Jan 31, 2022
@Hipska Hipska self-requested a review January 31, 2022 19:38
internal/snmp/translate.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding-wise it looks okay for me, but I don't see why this change is needed.

@MyaLongmire MyaLongmire marked this pull request as draft February 6, 2022 02:11
@MyaLongmire MyaLongmire marked this pull request as ready for review February 7, 2022 18:04
internal/snmp/translate_test.go Outdated Show resolved Hide resolved
internal/snmp/translate_test.go Outdated Show resolved Hide resolved
internal/snmp/translate_test.go Outdated Show resolved Hide resolved
@Hipska Hipska mentioned this pull request Feb 14, 2022
7 tasks
@telegraf-tiger
Copy link
Contributor

@MyaLongmire MyaLongmire merged commit d18ff34 into master Feb 16, 2022
@MyaLongmire MyaLongmire deleted the snmp-folder-loading branch February 16, 2022 19:25
powersj pushed a commit that referenced this pull request Feb 16, 2022
phemmer added a commit to phemmer/telegraf that referenced this pull request Feb 18, 2022
* origin/master: (211 commits)
  feat: update configs (influxdata#10676)
  feat[elastic output]: add elastic pipeline flags (influxdata#10505)
  Update changelog
  fix: ensure folders do not get loaded more than once (influxdata#10551)
  docs: update VMWare doc links (influxdata#10663)
  fix: prometheusremotewrite wrong timestamp unit (influxdata#10547)
  feat: update configs (influxdata#10662)
  fix: add graylog toml tags (influxdata#10660)
  feat: add socks5 proxy support for kafka output plugin (influxdata#8192)
  docs: override reported OpenSearch version (influxdata#10586)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10659)
  fix: bump all go.opentelemetry.io dependencies (influxdata#10647)
  feat: collection offset implementation (influxdata#10545)
  chore: update go to 1.17.7 (influxdata#10658)
  fix: check for nil client before closing in amqp (influxdata#10635)
  fix: timestamp change during execution of json_v2 parser. (influxdata#10657)
  fix: bump github.com/signalfx/golib/v3 from 3.3.38 to 3.3.43 (influxdata#10652)
  fix: bump github.com/aliyun/alibaba-cloud-sdk-go (influxdata#10653)
  fix: incorrect handling of json_v2 timestamp_path (influxdata#10618)
  feat: gather additional stats from memcached (influxdata#10641)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10649)
  fix: Revert deprecation of http_listener_v2 (influxdata#10648)
  fix: bump github.com/denisenkom/go-mssqldb from 0.10.0 to 0.12.0 (influxdata#10503)
  fix: bump github.com/gopcua/opcua from 0.2.3 to 0.3.1 (influxdata#10626)
  fix: use current time as ecs timestamp (influxdata#10636)
  fix: bump github.com/nats-io/nats-server/v2 from 2.6.5 to 2.7.2 (influxdata#10638)
  chore: add -race flag to go tests (influxdata#10629)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10631)
  fix: license doc outdated causing CI failure (influxdata#10630)
  fix: bump k8s.io/client-go from 0.22.2 to 0.23.3 (influxdata#10589)
  feat: Implemented support for reading raw values, added tests and doc (influxdata#6501)
  fix: Improve parser tests by using go-cmp/cmp (influxdata#10497)
  feat(mongodb): add FsTotalSize and FsUsedSize informations (influxdata#10625)
  docs: update quay docs for auth (influxdata#10612)
  chore: allow downgrade of go version in windows script (influxdata#10614)
  chore: update CI go to 1.17.6 (influxdata#10611)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10600)
  fix(inputs.opcua): add more data to error log (influxdata#10465)
  fix: bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.6.0 to 1.13.0 (influxdata#10601)
  refactor: use early return pattern (influxdata#10591)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp fix pr to fix corresponding bug
Projects
None yet
4 participants