Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in docs #10441

Merged
merged 4 commits into from
Jan 25, 2022
Merged

fix: typo in docs #10441

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bed7655
fix: remove dead link from docs
MyaLongmire Jan 13, 2022
76a9c26
fix: typo
Jan 25, 2022
afb854f
fix: linter
Jan 25, 2022
4622323
Update plugins/parsers/xpath/README.md
MyaLongmire Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/parsers/xpath/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ For supported XPath functions check [the underlying XPath library][xpath lib].
| [Extensible Markup Language (XML)][xml] | `"xml"` | |
| [JSON][json] | `"xpath_json"` | |
| [MessagePack][msgpack] | `"xpath_msgpack"` | |
| [Protocol buffers][protobuf] | `"xpath_protobuf"` | [see additional parameters](protocol-buffers-additiona-settings)|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan did you mean to include another doc for protobuf back when you added support?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest this should refer to the subsection below (line 18) but it seems I do have a typo there (protocol-buffers-additiona-settings vs the correct protocol-buffers-additional-settings)... :-(

| [Protocol buffers][protobuf] | `"xpath_protobuf"` | [see additional parameters](#protocol-buffers-additional-settings)|

### Protocol buffers additional settings

Expand Down