fix: typo in docs #10441
Merged
fix: typo in docs #10441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
approved these changes
Jan 13, 2022
reimda
reviewed
Jan 13, 2022
| | [Extensible Markup Language (XML)][xml] | `"xml"` | | | ||
| | [JSON][json] | `"xpath_json"` | | | ||
| | [MessagePack][msgpack] | `"xpath_msgpack"` | | | ||
| | [Protocol buffers][protobuf] | `"xpath_protobuf"` | [see additional parameters](protocol-buffers-additiona-settings)| |
There was a problem hiding this comment.
@srebhan did you mean to include another doc for protobuf back when you added support?
There was a problem hiding this comment.
To be honest this should refer to the subsection below (line 18) but it seems I do have a typo there (protocol-buffers-additiona-settings vs the correct protocol-buffers-additional-settings)... :-(
|
@MyaLongmire it's a typo and therefore dead (see my comment to @reimda's comment). Could you maybe just fix the link instead of removing it? |
sspaink
reviewed
Jan 25, 2022
Co-authored-by: Sebastian Spaink <3441183+sspaink@users.noreply.github.com>
|
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
sspaink
approved these changes
Jan 25, 2022
reimda
pushed a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit b2cfbb1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #
Removes a link that leads to a 404 (I went through the file history and it never linked to anything that exsisted) and removes the section of the table as that was the only entry