feat: Add noise plugin #10057

shypard · 2021-11-04T08:06:06Z

This PR adds a noise plugin which uses various probability density functions (Laplace, Gaussian, Uniform) to generate a random value, which is then used to modify the original field value. Exclusions for fields or metrics can be configured in the config file.

Required for all PRs:

Updated associated README.md.
Wrote appropriate unit tests.
Pull request title or commits are in conventional commit format

resolves #10012

srebhan

Wow this is already quite nice @wizarq! Nevertheless, I have some comments. Please take a look and let me know once you are done.

plugins/processors/noise/README.md

plugins/processors/noise/noise.go

plugins/processors/noise/noise_test.go

srebhan

Thanks for the update @wizarq! Some more comments in the code, especially moving the fieldFilter and noise variables to the struct instead of using global variables and the use of the distuv.Rander interface.

Furthermore, you have to add gonum.org/v1/gonum to the license list in docs/LICENSE_OF_DEPENDENCIES.md. Note the alphabetic order in that file. :-)

plugins/processors/noise/noise.go

srebhan

Thanks for the very nice update @wizarq! I have some comments on the overflow/underflow checks and usage of table-based tests. Please take a look there.

plugins/processors/noise/README.md

plugins/processors/noise/noise.go

plugins/processors/noise/noise_test.go

telegraf-tiger · 2021-11-11T08:56:28Z

⚠️ This pull request increases the Telegraf binary size by 1.07 % for linux amd64 (new size: 132.9 MB, nightly size 131.5 MB)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them **here**! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_armv7.tar.gz
armhf.deb	i386.rpm	freebsd_i386.tar.gz
i386.deb	ppc64le.rpm	linux_amd64.tar.gz
mips.deb	s390x.rpm	linux_arm64.tar.gz
mipsel.deb	x86_64.rpm	linux_armel.tar.gz
ppc64el.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

srebhan

@wizarq nice update and I think we are almost there. Some minor comments remain though... Keep up the good work!

plugins/processors/noise/README.md

plugins/processors/noise/noise.go

plugins/processors/noise/noise_test.go

srebhan

Very good. Please remove the section from the sample config (see my comment) and fix the linter issues in README.md then we are good to go (click on "Details" next to the red "X" for the findings)...

plugins/processors/noise/noise.go

srebhan

Looks good to me. Thanks for your effort @wizarq!

reimda

Thanks for the PR. Great test coverage!

plugins/processors/noise/README.md

plugins/processors/noise/noise.go

go.mod

plugins/processors/noise/README.md

plugins/processors/noise/noise.go

srebhan

@wizarq I have two more comments. Furthermore, I'm not sure on how to proceed with the metric.Now() inherent type conversion, so I'll leave this to the other guys. ;-)

srebhan

Beautiful @wizarq, just beautiful. Looks good to me. Thanks @wizarq for your effort!

reimda · 2022-01-11T22:44:34Z

@wizarq Could you resolve the go.mod conflict and we'll merge this? Thanks again!

shypard · 2022-01-12T09:49:00Z

@wizarq Could you resolve the go.mod conflict and we'll merge this? Thanks again!

I fixed the conflict in go.mod and synced the branch to the current head. The circleci however fails because of some non-related TestCSVMultiHeaderWithSkipRowANDColumn test.

telegraf-tiger · 2022-01-12T15:09:57Z

⚠️ This pull request increases the Telegraf binary size by 1.58 % for linux amd64 (new size: 136.4 MB, nightly size 134.3 MB)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

Hipska · 2022-01-12T15:46:47Z

plugins/processors/noise/README.md

+  noise_type = "laplacian"
+  include_fields = []
+  exclude_fields = ["usage_steal", "usage_user", "uptime_format", "usage_idle" ]
+  namedrop = ["swap", "disk", "net"]


Using namepass = ["cpu"] would make more sense in my opinion.

feat: implement noise plugin

489c897

srebhan reviewed Nov 4, 2021

View reviewed changes

srebhan self-assigned this Nov 4, 2021

srebhan added new plugin plugin/processor labels Nov 4, 2021

Christian Schaefer and others added 3 commits November 4, 2021 17:41

fix: implement review feedback - part1

99eb435

Merge branch 'influxdata:master' into plugin-noise

32af300

fix: implement review feedback - part2

da8adb8

srebhan requested changes Nov 5, 2021

View reviewed changes

shypard and others added 3 commits November 8, 2021 08:21

Merge branch 'influxdata:master' into plugin-noise

a4e1d5d

Merge remote-tracking branch 'upstream/master' into plugin-noise

fcc64a4

fix: implement review feedback

9c4242b

srebhan reviewed Nov 10, 2021

View reviewed changes

Christian Schaefer added 3 commits November 12, 2021 12:37

fix: implement review

529a8be

fix: implement review feedback

f0300fa

Merge remote-tracking branch 'upstream/master' into dev

ec814d0

srebhan reviewed Nov 16, 2021

View reviewed changes

Christian added 2 commits November 18, 2021 16:54

Merge remote-tracking branch 'upstream/master' into plugin-noise

2a91ae4

fix: implement review

dba879f

srebhan reviewed Nov 23, 2021

View reviewed changes

plugins/processors/noise/noise.go Outdated Show resolved Hide resolved

Christian added 2 commits November 29, 2021 12:43

fix: Implement review feedback

8a53eca

Merge remote-tracking branch 'upstream/master' into plugin-noise

0fe4952

srebhan approved these changes Nov 30, 2021

View reviewed changes

srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 30, 2021

reimda reviewed Dec 9, 2021

View reviewed changes

plugins/processors/noise/README.md Show resolved Hide resolved

plugins/processors/noise/README.md Show resolved Hide resolved

plugins/processors/noise/noise.go Show resolved Hide resolved

plugins/processors/noise/noise.go Outdated Show resolved Hide resolved

srebhan requested a review from reimda December 14, 2021 08:43

fix: Implement review feedback

38ffeec

shypard requested a review from srebhan December 23, 2021 13:56

shypard requested a review from powersj January 5, 2022 16:48

srebhan reviewed Jan 6, 2022

View reviewed changes

go.mod Show resolved Hide resolved

plugins/processors/noise/README.md Outdated Show resolved Hide resolved

plugins/processors/noise/noise.go Show resolved Hide resolved

srebhan reviewed Jan 6, 2022

View reviewed changes

Christian added 2 commits January 7, 2022 08:48

Merge remote-tracking branch 'upstream/master' into plugin-noise

8695b40

fix: Implement feedback, fix linter

adf3c45

shypard requested a review from srebhan January 7, 2022 08:21

srebhan approved these changes Jan 11, 2022

View reviewed changes

srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 11, 2022

reimda approved these changes Jan 11, 2022

View reviewed changes

Christian added 2 commits January 12, 2022 10:18

Merge remote-tracking branch 'upstream/master' into plugin-noise

cf8746c

fix: move gonum dependency to direct

60353b0

powersj approved these changes Jan 12, 2022

View reviewed changes

powersj merged commit a6b998f into influxdata:master Jan 12, 2022

Hipska reviewed Jan 12, 2022

View reviewed changes

powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022

feat: Add noise plugin (influxdata#10057)

030579a

powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022

feat: Add noise plugin (influxdata#10057)

6424738

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add noise plugin #10057

feat: Add noise plugin #10057

shypard commented Nov 4, 2021 •

edited

Loading

srebhan left a comment

srebhan left a comment

srebhan left a comment

telegraf-tiger bot commented Nov 11, 2021

Artifact URLs

srebhan left a comment

srebhan left a comment

srebhan left a comment

reimda left a comment

srebhan left a comment

srebhan left a comment

reimda commented Jan 11, 2022

shypard commented Jan 12, 2022

telegraf-tiger bot commented Jan 12, 2022

Artifact URLs

Hipska Jan 12, 2022

feat: Add noise plugin #10057

feat: Add noise plugin #10057

Conversation

shypard commented Nov 4, 2021 • edited Loading

Required for all PRs:

srebhan left a comment

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

telegraf-tiger bot commented Nov 11, 2021

Artifact URLs

srebhan left a comment

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

reimda left a comment

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

reimda commented Jan 11, 2022

shypard commented Jan 12, 2022

telegraf-tiger bot commented Jan 12, 2022

Artifact URLs

Hipska Jan 12, 2022

Choose a reason for hiding this comment

shypard commented Nov 4, 2021 •

edited

Loading