fix: avoid SIGBUS when reading non-std series segment files (#24509) #24520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some series files which are smaller than the standard sizes cause SIGBUS in influx_inspect and influxd, because entry iteration walks onto mapped memory not backed by the the file. Avoid walking off the end of the file while iterating series entries in oddly sized files. closes #24508 Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com> (cherry picked from commit 969abf3) closes #24511
davidby-influx
added
area/tsm
kind/bug
area/2.x
jeffreyssmith2nd
approved these changes
Dec 19, 2023
davidby-influx
added a commit
that referenced
this pull request
Dec 19, 2023
…24520) Some series files which are smaller than the standard sizes cause SIGBUS in influx_inspect and influxd, because entry iteration walks onto mapped memory not backed by the the file. Avoid walking off the end of the file while iterating series entries in oddly sized files. closes #24508 Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com> (cherry picked from commit 969abf3) closes #24511 (cherry picked from commit 081f951) closes #24512
davidby-influx
added a commit
that referenced
this pull request
Dec 20, 2023
…24520) (#24521) Some series files which are smaller than the standard sizes cause SIGBUS in influx_inspect and influxd, because entry iteration walks onto mapped memory not backed by the the file. Avoid walking off the end of the file while iterating series entries in oddly sized files. closes #24508 Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com> (cherry picked from commit 969abf3) closes #24511 (cherry picked from commit 081f951) closes #24512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some series files which are smaller than the standard sizes cause SIGBUS in influx_inspect and influxd, because entry iteration walks onto mapped memory not backed by the the file. Avoid walking off the end of the file while iterating series entries in oddly sized files.
closes #24508
Co-authored-by: Geoffrey Wossum gwossum@influxdata.com
(cherry picked from commit 969abf3)
closes #24511