Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_series segment files can cause SIGBUS in influxd and influx_inspect #24508

Closed
davidby-influx opened this issue Dec 6, 2023 · 0 comments
Closed

_series segment files can cause SIGBUS in influxd and influx_inspect #24508

davidby-influx opened this issue Dec 6, 2023 · 0 comments
Assignees
@davidby-influx
Labels
1.x area/tsm kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

We have encountered customer series segment files that can cause influxd ad influx_inspect to fail with SIGBUS,

These files are smaller than the standard sizes (whether through compaction or erroneous truncation), and the
SeriesSegment.ForEachEntry and Verify.VerifySegment functions can attempt to read the memory that has been
mmaped but is not actually in the file.
@davidby-influx davidby-influx self-assigned this Dec 6, 2023
davidby-influx added a commit that referenced this issue Dec 6, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files
e82ffeb 
Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508
This was referenced Dec 6, 2023
Merged
Closed
Closed
Closed
davidby-influx added a commit that referenced this issue Dec 8, 2023
@davidby-influx @gwossum
fix: avoid SIGBUS when reading non-std series segment files (#24509)
969abf3 
Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
davidby-influx added a commit that referenced this issue Dec 12, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files (#24509)
d747221 
Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
(cherry picked from commit 969abf3)

closes #24510
@davidby-influx davidby-influx mentioned this issue Dec 12, 2023
Merged
davidby-influx added a commit that referenced this issue Dec 12, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files (#24509) (#…
7116861 
…24515)

Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
(cherry picked from commit 969abf3)

closes #24510
davidby-influx added a commit that referenced this issue Dec 19, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files (#24509)
4a89f1a 
Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
(cherry picked from commit 969abf3)

closes #24511
@davidby-influx davidby-influx mentioned this issue Dec 19, 2023
Merged
davidby-influx added a commit that referenced this issue Dec 19, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files (#24509) (#…
081f951 
…24520)

Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
(cherry picked from commit 969abf3)

closes #24511
davidby-influx added a commit that referenced this issue Dec 19, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files (#24509) (#…
6f15424 
…24520)

Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
(cherry picked from commit 969abf3)

closes #24511

(cherry picked from commit 081f951)

closes #24512
@davidby-influx davidby-influx mentioned this issue Dec 19, 2023
Merged
davidby-influx added a commit that referenced this issue Dec 20, 2023
@davidby-influx
fix: avoid SIGBUS when reading non-std series segment files (#24509) (#…
535e869 
…24520) (#24521)

Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes #24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
(cherry picked from commit 969abf3)

closes #24511

(cherry picked from commit 081f951)

closes #24512
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this issue Aug 11, 2024
@davidby-influx @gwossum @chengshiwen
fix: avoid SIGBUS when reading non-std series segment files (influxda…
9645aa2 
…ta#24509)

Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes influxdata#24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
chengshiwen pushed a commit to chengshiwen/influxdb-cluster that referenced this issue Aug 25, 2024
@davidby-influx @gwossum @chengshiwen
fix: avoid SIGBUS when reading non-std series segment files (#24509)
fd3c62c 
Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes influxdata/influxdb#24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this issue Aug 27, 2024
@davidby-influx @gwossum @chengshiwen
fix: avoid SIGBUS when reading non-std series segment files (influxda…
ce3209d 
…ta#24509)

Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes influxdata#24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
chengshiwen pushed a commit to chengshiwen/influxdb-cluster that referenced this issue Aug 28, 2024
@davidby-influx @gwossum @chengshiwen
fix: avoid SIGBUS when reading non-std series segment files (#24509)
a7bb135 
Some series files which are smaller than the standard
sizes cause SIGBUS in influx_inspect and influxd, because
entry iteration walks onto mapped memory not backed by the
the file.  Avoid walking off the end of the file while
iterating series entries in oddly sized files.

closes influxdata/influxdb#24508

Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/tsm kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidby-influx