refactor(http): remove the spec and update lang usage #17148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
requested review from
a team and
jpacik
and removed request for
a team
|
The spec is currently unused? |
|
To my knowledge the repl no longer uses the repl endpoint since it was only used by the querier interface within influx. |
rockstar
approved these changes
Mar 9, 2020
|
It looks like I didn't modifying the mock compiler in the flux repository for the new interface and it is used by influxdb. |
This removes the spec and updates the lang package usage to make use of passing in the runtime as a parameter. It removes all direct dependendencies on the flux runtime from the http package.
jsternberg
force-pushed
the
refactor/libflux-lang-and-spec
branch
from
b0e4cb5 to
a920c20
Compare
jpacik
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the spec and updates the lang package usage to make use of
passing in the runtime as a parameter.
It removes all direct dependendencies on the flux runtime from the http
package.