refactor: mock compiler needs to implement the compiler interface #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
requested review from
a team and
ethanyzhang
and removed request for
a team
jsternberg
force-pushed
the
refactor/mock-compiler
branch
from
7c69df5 to
d33b410
Compare
Codecov Report
@@ Coverage Diff @@
## feat/use-algo-w #2601 +/- ##
===================================================
+ Coverage 51.29% 51.29% +<.01%
===================================================
Files 300 300
Lines 38507 38507
===================================================
+ Hits 19752 19754 +2
+ Misses 16548 16547 -1
+ Partials 2207 2206 -1
Continue to review full report at Codecov.
|
ethanyzhang
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done checklist