Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

chore(client_test): adding in an old test from legacy PR#315 #752

Merged
merged 3 commits into from
Sep 4, 2019

Conversation

sebito91
Copy link
Contributor

@sebito91 sebito91 commented Sep 4, 2019

This PR closes out a legacy PR #315 that is no longer maintained by the original author, @oldmantaiter. We shamelessly steal the tests and add them in here.

@sebito91 sebito91 self-assigned this Sep 4, 2019
@aviau
Copy link
Collaborator

aviau commented Sep 4, 2019

You seem to be missing the actual code!

@sebito91
Copy link
Contributor Author

sebito91 commented Sep 4, 2019

The code is already there, added somewhere since 2016 when the PR was first opened!

@aviau
Copy link
Collaborator

aviau commented Sep 4, 2019

Ahhh! Alright then

@aviau
Copy link
Collaborator

aviau commented Sep 4, 2019

🚢 🇮🇹

@sebito91
Copy link
Contributor Author

sebito91 commented Sep 4, 2019

Working to clear out the backlog!

@sebito91 sebito91 removed the request for review from xginn8 September 4, 2019 03:53
@sebito91 sebito91 merged commit 6baf7ee into master Sep 4, 2019
@sebito91 sebito91 deleted the shard_duration_test branch September 4, 2019 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants