This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Add support for shard duration in retention policies #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase your PR? (or just merge master in your branch) (please GitHub, give me a rebase button like Gerrit) |
oldmantaiter
force-pushed
the
add-shard-duration
branch
from
77b1cd0 to
0347450
Compare
|
Can you please fix the corresponding tests? |
|
@aviau Yep. |
oldmantaiter
force-pushed
the
add-shard-duration
branch
from
0347450 to
7a56f1e
Compare
- SHARD DURATION was added in 45b3e61, this adds support to the python client so it can be modified/added
oldmantaiter
force-pushed
the
add-shard-duration
branch
from
7a56f1e to
9efe5e7
Compare
|
@oldmantaiter any chance you could please rebase with master and test? This looks solid, and is a good catch. @aviau this looks good to me, ready to merge. |
|
Wow, missed this update entirely. I'll see what I can do @sebito91 - I'm not using this library anymore so I'll need to do a bit of catchup. |
|
My apologies for not getting back into this, I’ll close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client so it can be modified/added