Fix label naming inconsistency and document workflow migration requirements#6893
Merged
jstirnaman merged 2 commits intoclaude/triage-agent-plan-EOY0ufrom Mar 1, 2026
Merged
Conversation
3 tasks
- Rename review:approved to approval:codeowner to avoid confusion with review/* labels - Add note explaining the distinct prefix to prevent implementor confusion - Document required workflow updates for sync-plugin-docs label migration - Specify exact files and line numbers that need updating Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update document review pipeline implementation plan
Fix label naming inconsistency and document workflow migration requirements
Mar 1, 2026
jstirnaman
reviewed
Mar 1, 2026
| | `approval:codeowner` | Codeowner approved | | ||
|
|
||
| > [!Note] | ||
| > The `approval:codeowner` label uses a distinct prefix (`approval:`) to avoid confusion with the `review/*` labels, which represent **automated review outcomes** from the doc review pipeline. |
Contributor
There was a problem hiding this comment.
@copilot Why do some use slashes and others use colons?
Contributor
Author
There was a problem hiding this comment.
The separators follow GitHub label conventions based on their purpose:
Colons (:) = Namespace/category prefixes for organizational grouping:
product:v3-monolith,product:telegrafsource:auto-detected,source:manualwaiting:engineering,approval:codeownerai:tooling,ci:testing
Slashes (/) = Hierarchical state values (GitHub's native pattern for mutually exclusive states):
review/approved,review/changes-requested,review/needs-human
This matches GitHub's own convention (e.g., type/bug, status/in-progress) where slashes indicate "pick one from this set" while colons create organized label families that can be applied together.
jstirnaman
requested review from
sanderson
and removed request for
a team and
sanderson
jstirnaman
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on the document review pipeline implementation plan regarding label taxonomy clarity and migration requirements.
Changes
Label naming: Renamed
review:approved→approval:codeownerto distinguish human approval workflow state from automatedreview/*outcome labelsWorkflow migration requirements: Documented GitHub Actions files requiring updates when migrating
sync-plugin-docs→source:auto-detected.github/workflows/sync-plugins.yml(lines 28, 173, 421).github/ISSUE_TEMPLATE/sync-plugin-docs.yml(line 4)Context
The original plan used both
review:(colon) andreview/(slash) prefixes, which would confuse both humans and automation. The rename creates clear separation:approval:approval:codeownerreview/review/approved,review/changes-requestedThe
sync-plugin-docslabel is actively used in automation workflows that would break silently after label migration without explicit documentation of required updates.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.