Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: unnecessary auto-increment calculations in the tokens statistics of the chat model #2969

Merged
merged 4 commits into from
Oct 22, 2024
Merged

[Bug]: unnecessary auto-increment calculations in the tokens statistics of the chat model #2969

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f27c7b6
[Bug]: When use OpenAI chat model , raise ERROR: 'CompletionUsage' ob…
yqwang96 Oct 22, 2024
e1ffb7b
Merge branch 'main' into main
KevinHuSh Oct 22, 2024
e9e8540
change wrong total_tokens calculate method
yqwang96 Oct 22, 2024
d9caaa3
Merge branch 'main' into main
yqwang96 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rag/llm/chat_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def chat_streamly(self, system, history, gen_conf):
resp.choices[0].delta.content = ""
ans += resp.choices[0].delta.content

total_tokens += 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for case if not hasattr(resp, "usage") or not resp.usage:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't understand why we need to do total_tokens += 1 every time? Indeed, it only works when if not hasattr(resp, "usage") or not resp.usage is satisfied, so why not put this statement inside the statement?
Anyway, if total_tokens += 1 needs to be executed, then there is no problem with the current code.
But I don't understand why we need to do this? Could you please explain it to me? Many thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable.

if not hasattr(resp, "usage") or not resp.usage:
total_tokens = (
total_tokens
Expand Down