[Bug]: unnecessary auto-increment calculations in the tokens statistics of the chat model #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHuSh
reviewed
Oct 22, 2024
| @@ -68,7 +68,6 @@ def chat_streamly(self, system, history, gen_conf): | |||
| resp.choices[0].delta.content = "" | |||
| ans += resp.choices[0].delta.content | |||
|
|
|||
| total_tokens += 1 | |||
There was a problem hiding this comment.
This is just for case if not hasattr(resp, "usage") or not resp.usage:
There was a problem hiding this comment.
But I don't understand why we need to do total_tokens += 1 every time? Indeed, it only works when if not hasattr(resp, "usage") or not resp.usage is satisfied, so why not put this statement inside the statement?
Anyway, if total_tokens += 1 needs to be executed, then there is no problem with the current code.
But I don't understand why we need to do this? Could you please explain it to me? Many thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
the details is shown in #2968
Type of change