Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.1.3 beta #113

Merged
merged 4 commits into from
Apr 21, 2021
Merged

V0.1.3 beta #113

merged 4 commits into from
Apr 21, 2021

Conversation

AndrewCopeland
Copy link
Collaborator

infamousjoeg and others added 4 commits April 16, 2021 15:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

@AndrewCopeland AndrewCopeland merged commit 2fb89d2 into main Apr 21, 2021
infamousjoeg added a commit that referenced this pull request May 7, 2021
@mdaguete @AndrewCopeland
@quincycheng @infamousjoeg
Improve logon with 2FA (#114)
72941de 
* V0.1.3 beta (#113)

* Fixes #108 add authn ldap support (#109)
* Fixes #106 Adding 6 CEM sub-commands (#105) (#111)

Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com>
Co-authored-by: Joe Garcia <infamousjoeg@users.noreply.github.com>

* Improve logon with 2FA

Currenly when trying to autenticate against a CyberArk with 2FA enabled the
request request fails with the following error:

    Failed to Logon to the PVWA. Failed to authenticate to the PAS REST API.
    Received non-200 status code '500'

In function `httpjson.SendRequestRay` the response body isn't returned, so
the caller function never finds the correct error code.

After the previous fix, the second call, the one with the otp code still fails
with 403. Debugging it seems that we need to store the cookies between the
two logon calls. So a go context is added to the functions.

* Fix lint errors and add missing file from previous commit

This commit fixes the go  lint error related to key type in context and it
adds a missing file from previous commit not uploaded by error.

* Fix type error in comment

* Missing comment on Cookie function

Added missing comment

* Fix panic when body response is nil

Try to catch nil response body on httpjson.SendRequestRaw function

Co-authored-by: Andrew Copeland <50109276+AndrewCopeland@users.noreply.github.com>
Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com>
Co-authored-by: Joe Garcia <infamousjoeg@users.noreply.github.com>
@infamousjoeg infamousjoeg mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support authn-ldap conjur logon
2 participants
@AndrewCopeland @infamousjoeg