Fixes #108 add authn ldap support #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infamousjoeg
added
enhancement
AndrewCopeland
requested changes
Apr 7, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
AndrewCopeland
added a commit
that referenced
this pull request
Apr 21, 2021
infamousjoeg
added a commit
that referenced
this pull request
May 7, 2021
* V0.1.3 beta (#113) * Fixes #108 add authn ldap support (#109) * Fixes #106 Adding 6 CEM sub-commands (#105) (#111) Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com> Co-authored-by: Joe Garcia <infamousjoeg@users.noreply.github.com> * Improve logon with 2FA Currenly when trying to autenticate against a CyberArk with 2FA enabled the request request fails with the following error: Failed to Logon to the PVWA. Failed to authenticate to the PAS REST API. Received non-200 status code '500' In function `httpjson.SendRequestRay` the response body isn't returned, so the caller function never finds the correct error code. After the previous fix, the second call, the one with the otp code still fails with 403. Debugging it seems that we need to store the cookies between the two logon calls. So a go context is added to the functions. * Fix lint errors and add missing file from previous commit This commit fixes the go lint error related to key type in context and it adds a missing file from previous commit not uploaded by error. * Fix type error in comment * Missing comment on Cookie function Added missing comment * Fix panic when body response is nil Try to catch nil response body on httpjson.SendRequestRaw function Co-authored-by: Andrew Copeland <50109276+AndrewCopeland@users.noreply.github.com> Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com> Co-authored-by: Joe Garcia <infamousjoeg@users.noreply.github.com>
infamousjoeg
added a commit
that referenced
this pull request
Jun 7, 2021
* Fixes #108 add authn ldap support (#109) - Fixes #108 add authn ldap support (#109) * Adding 6 CEM sub-commands (#105) (#111) * Resolves #106 Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com> * Create alias's and simplified command for CEM * update docs Co-authored-by: Andrew Copeland <50109276+AndrewCopeland@users.noreply.github.com> Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com> Co-authored-by: AndrewCopeland <andcope1995@gmail.com>
infamousjoeg
added a commit
that referenced
this pull request
Jun 7, 2021
* Fixes #108 add authn ldap support (#109) - Fixes #108 add authn ldap support (#109) * Adding 6 CEM sub-commands (#105) (#111) * Resolves #106 Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com> * Create alias's and simplified command for CEM * update docs * Fix #117 list safes response (#118) * fix responses for ListSafe * value not values Co-authored-by: Andrew Copeland <50109276+AndrewCopeland@users.noreply.github.com> Co-authored-by: Quincy Cheng <quincy.cheng@gmail.com> Co-authored-by: AndrewCopeland <andcope1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.