Team page changes #214
Team page changes #214
Conversation
SibiAkkash
force-pushed
the
optimise-team-view
branch
3 times, most recently
from
81d87eb
to
b815711
Compare
|
Nice this is super cool Just a few thoughts in UI: Can we reduce the number of skeletons of Roster and Matches? I feel just 5 in roster and 3 in matches will be enough.. Currently it feels page is super long when loading only @SibiAkkash |
| return ( | ||
| <div class="mb-10"> | ||
| <div class="mb-5 ml-1"> | ||
| <h3 class="text-center text-lg font-bold">Day - 1</h3> |
There was a problem hiding this comment.
When showing skeletons dont think we need to show day as there might be 1 day / 3 day tournaments which this might confuse
There was a problem hiding this comment.
so, just Roster, followed by the skeletons for the matches ? Shall we have Day - 1 alone ? Otherwise there'd be a small jump when the matches query completes and is rendered right ?
In the skeletons there won't be the Day - 1 heading, suddenly it will appear once matches are fetched and grouped.
There was a problem hiding this comment.
Although you might need to update this for the tab view here as well
SibiAkkash
force-pushed
the
optimise-team-view
branch
from
67d250e
to
8a8550d
Compare
SibiAkkash
force-pushed
the
optimise-team-view
branch
2 times, most recently
from
2381d60
to
1651eff
Compare
SibiAkkash
force-pushed
the
optimise-team-view
branch
from
1651eff
to
0cdb65c
Compare
SibiAkkash
force-pushed
the
optimise-team-view
branch
2 times, most recently
from
b233b94
to
61ad1c3
Compare
Matches, Pools and Bracket responses don't need to include tournament data Due to relations to tournament and pools in the matches model, we end up sending the tournament object multiple times in the response
SibiAkkash
force-pushed
the
optimise-team-view
branch
2 times, most recently
from
36b4db5
to
3800a08
Compare
|
Skeletons for standing tabs standings-skeleton-2023-12-04_18.34.50.mp4 |
|
Noice Perfect |
|
@SibiAkkash 10 might again be a lot for skeletons I think.. We can have 6 or less I feel.. Cause I think the skeleton list should not take a whole mobile screen. Also some tournaments we have from 3 / 4 teams like womens this time in that case the website will shrink after data loads. So better to go with less numbers |
Makes sense, changing to 6 |
|
skeleton for schedule schedule-skeleton-2023-12-04_21.07.41.mp4 |
SibiAkkash
force-pushed
the
optimise-team-view
branch
from
d512c3d
to
2096a28
Compare
SibiAkkash
force-pushed
the
optimise-team-view
branch
from
2096a28
to
5207b2c
Compare
|
@SibiAkkash Will you be doing skeletons for standings page as well? |
Yeah, I can do this by tonight |
|
@SibiAkkash Can you please rebase this with the latest main and push? Will merge post that |
|
Closing as separate PRs have been created for these |
Added match skeletons #209
Fetch team matches only, part of fixing #199
team-page-skeletons-2023-11-25_16.16.35.mp4