-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show spirit scores along with results in match card #213
Conversation
fixes #202 as well |
Woah! @Joe2k is on fire! |
Hmm not so sure on that as it will take more space... and since we anyway showing the detailed split when the user clicks on button it should be fine? Also people wont know what is the order of criteria when we just put 2;2;2;2;2 and might just be confusing i think |
I think players would know the order, but fair enough that it's just a click away. May be we can make the spirit scores themselves clickable instead of the extra button to see Scores/MVP/MSP? |
Yeah, but then how we'll show/make user know that its clickable? |
Maybe use an arrow or make it like a button or something. I'm not sure. @SibiAkkash might have ideas. |
@SibiAkkash Any thoughts on this? If not I think we can merge this for now and think later.. |
The "Spirit Scores, MVP, MSP" button could be renamed to "Spirit : 10 - 10". |
yeah makes sense.. will do |
Updated @SibiAkkash @punchagan |
Rebased and Pushed... This is also ready to be reviewed and merged |
fixes #120