Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show spirit scores along with results in match card #213

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

Joe2k
Copy link
Contributor

@Joe2k Joe2k commented Nov 24, 2023

fixes #120

Screenshot 2023-11-24 at 11 01 37 PM

@Joe2k Joe2k self-assigned this Nov 24, 2023
@Joe2k
Copy link
Contributor Author

Joe2k commented Nov 24, 2023

Screenshot 2023-11-24 at 11 19 48 PM

Also added tabs in the team page for better accessibility and UX

@Joe2k
Copy link
Contributor Author

Joe2k commented Nov 24, 2023

fixes #202 as well
Screenshot 2023-11-24 at 11 41 19 PM

@punchagan
Copy link
Member

Woah! @Joe2k is on fire!

@punchagan
Copy link
Member

Screenshot 2023-11-24 at 11 19 48 PM

We could use full scores like 2;2;2;2;2 instead of 10?

@Joe2k
Copy link
Contributor Author

Joe2k commented Nov 24, 2023

We could use full scores like 2;2;2;2;2 instead of 10?

Hmm not so sure on that as it will take more space... and since we anyway showing the detailed split when the user clicks on button it should be fine?

Also people wont know what is the order of criteria when we just put 2;2;2;2;2 and might just be confusing i think

@punchagan
Copy link
Member

I think players would know the order, but fair enough that it's just a click away. May be we can make the spirit scores themselves clickable instead of the extra button to see Scores/MVP/MSP?

@Joe2k
Copy link
Contributor Author

Joe2k commented Nov 25, 2023

Yeah, but then how we'll show/make user know that its clickable?

@punchagan
Copy link
Member

Yeah, but then how we'll show/make user know that its clickable?

Maybe use an arrow or make it like a button or something. I'm not sure. @SibiAkkash might have ideas.

@Joe2k
Copy link
Contributor Author

Joe2k commented Dec 1, 2023

@SibiAkkash Any thoughts on this? If not I think we can merge this for now and think later..

@Joe2k Joe2k mentioned this pull request Dec 1, 2023
@SibiAkkash
Copy link
Contributor

SibiAkkash commented Dec 1, 2023

@SibiAkkash Any thoughts on this? If not I think we can merge this for now and think later..

The "Spirit Scores, MVP, MSP" button could be renamed to "Spirit : 10 - 10".
Or, like punch was saying we could have a small badge
Like the below pic, we could have "Spirit" in blue, the score "10-10" in gray, and add an arrow to indicate clickability
image

Or something simpler
Screenshot_20231201-135206~3.png

@Joe2k
Copy link
Contributor Author

Joe2k commented Dec 1, 2023

yeah makes sense.. will do

@Joe2k
Copy link
Contributor Author

Joe2k commented Dec 3, 2023

Updated @SibiAkkash @punchagan
Screenshot 2023-12-03 at 1 46 27 PM
Screenshot 2023-12-03 at 1 46 36 PM

@Joe2k
Copy link
Contributor Author

Joe2k commented Dec 5, 2023

Rebased and Pushed... This is also ready to be reviewed and merged
@punchagan

@Joe2k Joe2k merged commit 028133c into main Dec 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include spirit scores in the team view
3 participants