fix: convert special html symbols in page titles to understandable characters (resolves #387) #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyli
requested changes
Sep 10, 2020
eleventy.config.js
Outdated
| @@ -10,6 +10,7 @@ const dataFetcherAirtable = require("./src/utils/data-fetcher-airtable.js"); | |||
| const htmlMinifyTransform = require("./src/transforms/html-minify.js"); | |||
| const parseTransform = require("./src/transforms/parse.js"); | |||
| const dateFilter = require("./src/filters/date.js"); | |||
| const metaTitleFilter = require("./src/filters/meta-title.js"); | |||
There was a problem hiding this comment.
titleFilter might be a better name than metaTitleFilter.
src/js/utils.js
Outdated
| @@ -2,6 +2,17 @@ | |||
|
|
|||
| /* global convertDate, stripHtmlTags, htmlDecode, chunkArray, escapeSpecialChars */ | |||
|
|
|||
| /* | |||
| * Remove soft hyphens and replace ’ with apostrophe. | |||
| * @param {String} webpageString - A string with one or more soft hyphens or ’. | |||
There was a problem hiding this comment.
Probably better to rename webpageString to inputStr. In this case, try to pick a name that suits the function itself rather than the context you wanted to use this function.
src/js/utils.js
Outdated
| */ | ||
| // eslint-disable-next-line | ||
| metaTitle = function (webpageString) { | ||
| webpageString = webpageString.replace(/’/g, "’"); |
There was a problem hiding this comment.
It would be better to use a logic like:
const toReplace = {
"’": "’",
"­": ""
};
// Iterate thru toReplace object to replace every match.
When a new replacement needs to be added, extending the data in toReplace will be enough rather than copying the .replace() code over and over.
cindyli
changed the title
cindyli
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lintwithout errorsnpm run startand reviewing affected routesnpm run buildwithout errorsDescription
Remove
­from title tags on webpages with soft hyphens in title.Steps to test
<title>tag in the<head>tagExpected behavior:
­should not appearAdditional information
This PR also replaces
’with an apostrophe in title tags.Related issues
resolves #387