Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spp-001-nl mhq heide #69

Merged
merged 110 commits into from
Nov 28, 2023
Merged

spp-001-nl mhq heide #69

merged 110 commits into from
Nov 28, 2023

Conversation

Patrikoosterlynck
Copy link
Contributor

@Patrikoosterlynck Patrikoosterlynck commented Oct 20, 2022

Description

Veldprotocol kwaliteitsmeetnet heidehabitats

Related Issue

Task list

Steps by contributor:

  • Add description to this pull request (under "## Description")
  • Open the dropdown (triangle) near 'create pull request' and choose 'Create draft pull request'
  • Check for potential problems by running protocolhelper::check_frontmatter() and address them
  • Check for potential problems by running protocolhelper::check_structure() and address them
  • Add further commits if needed and push them to GitHub
  • Update the protocol-specific NEWS.Rmd
  • Mark the pull request as 'ready for review'

Review steps for the author(s):

  • Add reviewers, at least one subject-matter specialist and one administrator
  • Wait for review comments and address them
  • Iterate until reviewer approvals (merging the pull request will be done by an administrator)
  • Verify that the checks done by continuous integration succeeded. These will check if protocolhelper::check_frontmatter() and protocolhelper::check_structure() succeeded without errors.

To be done by an administrator after review: see guidelines for admins.

@Patrikoosterlynck Patrikoosterlynck marked this pull request as draft October 20, 2022 11:59
Patrikoosterlynck and others added 10 commits November 27, 2023 11:54
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
Co-authored-by: Toon Westra <toon.westra@inbo.be>
@ToonHub
Copy link
Collaborator

ToonHub commented Nov 27, 2023

Ik heb ook nog enkele inhoudelijke opmerkingen, maar die mogen ook in een volgende versie van het protocol aangepakt worden:

  • bij hermeting van een meetpunt uit eerste cyclus, wordt er in principe geen verplaatsing uitgevoerd als habitat niet meer aanwezig is. Er wordt dan best ook genoteerd wat de mogelijke oorzaak is van de verdwijning van het habitat. Wordt er dan sowieso ook een opname gedaan?
  • Voor sommige meetpunten volstaat de aanwezigheid van het (hoofd)habitattype voor opname. Andere meetpunten zijn specifiek geselecteerd voor een subtype en dat subtype moet dan ook aanwezig zijn.

@Patrikoosterlynck
Copy link
Contributor Author

Patrikoosterlynck commented Nov 27, 2023 via email

Copy link
Collaborator

@ToonHub ToonHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@hansvancalster hansvancalster merged commit e69aed9 into main Nov 28, 2023
3 of 4 checks passed
@hansvancalster hansvancalster deleted the spp-001-nl branch November 28, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants