-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick final launch translations into release branch #2852
Conversation
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
16447099 | Triggered | Generic Password | f103746 | src/i18n/l10n/fi.ftl | View secret |
16482708 | Triggered | Generic Password | f103746 | src/i18n/l10n/it.ftl | View secret |
16482709 | Triggered | Generic Password | f103746 | src/i18n/l10n/it.ftl | View secret |
16447100 | Triggered | Generic Password | f103746 | src/i18n/l10n/fi.ftl | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
||
iNaturalistin voittoa tavoittelematon tehtävä on yhdistää ihmiset luontoon ja edistää tiedettä ja luonnonsuojelua. iNaturalist on vapaasti käytettävissä lahjoittajayhteisömme runsaan tuen ansiosta. | ||
|
||
Tutustu ja opi vielä enemmän https://www.inaturalist.laji.fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL does not work. I don't think they are supposed to be translated actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll hand-fix that for this release once it's been auto-uploaded to the App Store, and have fixed it at the source, which—curiously—was added by a human translator last week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I tested by making a dev build, logging in, switching languages in the app, and checking the newest text (Analyzing...) in the loading PreMatch screen in a few different languages. Apparently the first few languages I picked all have the speediest translators (Danish, etc.) and they were already translated. I finally found a language (Turkish) that falls back to English to make sure that was working without crashes too.
Thanks for testing the fallback @albullington, that's helpful. I should have mentioned that another manual test I successfully performed today was to confirm that in regional dialects where we do not have a specific translation, we're correctly falling back to the primary language (i.e.: es-MX uses es-ES strings rather than falling back to en-US) |
New Crowdin translations by GitHub Action (#2842)
Closes MOB-620