Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin Translations #2842

Merged
merged 1 commit into from
Apr 10, 2025
Merged

New Crowdin Translations #2842

merged 1 commit into from
Apr 10, 2025

Conversation

kueda
Copy link
Member

@kueda kueda commented Apr 9, 2025

New Crowdin translations by Crowdin GH Action

Copy link

gitguardian bot commented Apr 10, 2025

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
16447099 Triggered Generic Password 866d21b src/i18n/l10n/fi.ftl.json View secret
16482708 Triggered Generic Password 866d21b src/i18n/l10n/it.ftl View secret
16482709 Triggered Generic Password 866d21b src/i18n/l10n/it.ftl View secret
16447100 Triggered Generic Password 866d21b src/i18n/l10n/fi.ftl View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@kvangork kvangork self-requested a review April 10, 2025 05:45
Copy link
Contributor

@kvangork kvangork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually running the Crowdin-pull GH action from an experimental branch copied an unintended commit (0eb9c66) onto l10n_main. Please do not merge this until I have a chance to clean it up.

Copy link
Contributor

@kvangork kvangork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spot-checked a few of the translations, and successfully smoke-tested a dev build

@kvangork kvangork merged commit 1006b3d into main Apr 10, 2025
11 checks passed
kvangork pushed a commit that referenced this pull request Apr 10, 2025
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants