Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick mob-622-rename-inat-next-to-inaturalist #2850

Merged

Conversation

kvangork
Copy link
Contributor

Rename iNat Next to iNaturalist

…-inaturalist

Rename iNat Next to iNaturalist

Closes MOB-622
Fixes MOB-672
@kvangork kvangork requested a review from jtklein April 10, 2025 04:18
Copy link
Collaborator

@jtklein jtklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve this in a sense that on installing the app I find everything to be with the correct name. I checked and fastlane ios build and e2e locally is also still running.
I can see some outdated references in the Maestro e2e tests that are still looking to start the "iNaturalistReactNative" app. We have never hooked those up into the CI though so, not a blocker I would say.
I can also see the name iNaturalistReactNative still as a label in this file here but I think it is not even used in the app anywhere:

<label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="iNaturalistReactNative" textAlignment="center" lineBreakMode="middleTruncation" baselineAdjustment="alignBaselines" minimumFontSize="18" translatesAutoresizingMaskIntoConstraints="NO" id="GJd-Yh-RWb">
<rect key="frame" x="0.0" y="202" width="375" height="43"/>

I am not versed enough in native iOS to understand the InfoPlist.xcstrings changes. So, I can only assume that a change from "new" to "needs_review" is correct.

@kvangork kvangork merged commit 7bc3c51 into release-1.0 Apr 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants