Rename iNat Next to iNaturalist #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albullington
requested changes
Apr 10, 2025
There was a problem hiding this comment.
Permissions now say iNaturalist & the name of the app on my iPhone home screen is iNaturalist. Requesting changes because:
- I'm not sure why the Tagalog translations were dropped from
InfoPlist.xcstrings. - I believe we also need to change
fastlane/metadata/ios/default/name.textfor the name to change in the App Store when we're building with Fastlane.
|
I've run a few experiemnts. Xcode's deleting the Tagalog section whenever anything (even unrelated to bundle name) is changed in Info.plist, and it's no longer available on my phone. I can't find any details online about Apple removing it, but I don't think its removal can negatively affect users. As for Fastlane...good catch. I'll change it there too, but its metadata upload been unreliable for me over the past couple of weeks so I'm planning to verify and edit the App Store metadata by hand for the final release.. |
albullington
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MOB-622
Fixes MOB-672
Forces the rename throughout the untranslatable elements of xcstrings rather than waiting for crowdin to do the same thing.