[Tests] no-unresolved: add tests for import()
#2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbonnet
changed the title
no-unresolved Check dynamic imports when using the built-in Eslint parserno-unresolved: Check dynamic imports when using the built-in Eslint parser
|
Thanks, the fix seems great. This is blocked for now on #1986, unfortunately. |
ljharb
approved these changes
May 12, 2021
ljharb
force-pushed
the
fix-dynamic-import
branch
from
2448a96
to
3c5e2c8
Compare
ljharb
force-pushed
the
fix-dynamic-import
branch
2 times, most recently
from
1fa34fb
to
834921a
Compare
aladdin-add
reviewed
May 12, 2021
| @@ -85,7 +92,7 @@ function runResolverTests(resolver) { | |||
| options: [{ commonjs: true }] }), | |||
| ], | |||
|
|
|||
| invalid: [ | |||
| invalid: [].concat( | |||
There was a problem hiding this comment.
just curious why the [].concat() is needed. :)
There was a problem hiding this comment.
because RuleTester requires an array of objects, so there's no way to conditionally provide an ignoreable value, so we have to use [].concat() and have the conditional helper return an empty array, since concat flatMaps over arrays.
ljharb
force-pushed
the
fix-dynamic-import
branch
2 times, most recently
from
5837636
to
14acb5b
Compare
|
@davidbonnet tests still seem to be failing here, so i think this one needs a bit more investigation. @aladdin-add if your PR can get the tests passing, that'd be great too. |
ljharb
force-pushed
the
fix-dynamic-import
branch
from
14acb5b
to
dd7d3a6
Compare
ljharb
changed the title
no-unresolved: Check dynamic imports when using the built-in Eslint parser
ljharb
changed the title
no-unresolved: add tests for import()
ljharb
force-pushed
the
fix-dynamic-import
branch
2 times, most recently
from
9d4a107
to
ad2a619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic imports landed in EcmaScript 2020, and Eslint now parses it out of the box.
However, the AST
nodecontaining the dynamic import is anImportExpression, which is ignored by theno-unresolvedrule.