npm 7 breaks tests

[ljharb]

As of npm 7's promotion yesterday, there's at least two problems breaking tests on master and every PR:

• peer dep issues. eslint 4 is incompatible with @typescript-eslint/parser. this is solved with --legacy-peer-deps (commit).
• when node_modules is present in the root, and was installed with npm 7, both npm 6 and 7 fail on a bunch of the resolver tests, and on a few of the root tests (presumably related). When node_modules is absent, or chmod a-x node_modules, or installed with npm 6, things are fine. (lockfile diff)

It's being looked into. After a few days of this, I'll probably try to downgrade npm on affected builds, but it might reflect an issue that npm 7 users will encounter, so I'd prefer to find a proper fix.

[exarus]

The plugin doesn't work with Yarn 2 PnP.

ESLint validation fails if there is any import present in code.
error Resolve error: unable to load resolver "node" import/no-duplicates

Explicitly installing eslint-import-resolver-node solves the issue.

This might be related to the npm 7 problem.

[ljharb]

@exarus indeed, but that's a bug in PnP, and not in the package. Specifically, https://github.com/benmosher/eslint-plugin-import/blob/master/package.json#L73 ensures it's available as a dev dep in the root package, just like https://github.com/benmosher/eslint-plugin-import/blob/master/package.json#L105 ensures it's available as a runtime dep for all consumers. The issue you're referring to is that consumers' npm install will hoist the eslint-import-resolver-node dep to the root, and yarn PnP incorrectly refuses to allow it to be imported unless the consuming package also explicitly lists it.

It's possible that listing it twice is exposing a bug in npm 7, though.

[merceyz]

indeed, but that's a bug in PnP [...] and yarn PnP incorrectly refuses to allow it to be imported unless the consuming package also explicitly lists it.

That's not a bug in PnP but in how the package is resolved, it's resolved relative to the config instead of the eslint plugin.

[arcanis]

That's not a bug in PnP but in how the package is resolved, it's resolved relative to the file getting checked instead of the eslint plugin.

Specifically, the hoisting behaviour you're expecting to kick in would lead eslint-plugin-import to access the wrong eslint-import-resolver-node versions in pathological npm and Yarn 1.x cases. This isn't just a theoretical issue, and is fairly well documented, including with examples how to break typical package manager installs.

[ljharb]

I'm going to hide the off-topic comments here; eslint-plugin-import has relied on consumers being able to resolve eslint-import-resolver-node for well over half a decade and it's worked perfectly for that time, and I'm pretty confident that this is not the issue here (altho, having the dep listed in both deps and devDeps may be).

[ljharb]

3c23c4c fixed the failures in the webpack resolver. It's certainly concerning that the presence of webpack breaks the webpack resolver, so that's something that needs looking into :-) See #1987.

After 85c137b which fixes eslint 2, tests are still failing in the root in eslint 3 and 4, but I'm having trouble reproducing locally.

[ljharb]

The following commits have unbroken tests on master:

• 4f64274: it seems likely that any repo that has to tests on multiple versions of a peer-deppable-thing may have to do this
• 3c23c4c: Tests: figure out why webpack resolver fails when webpack is present #1987
• 85c137b: a strict improvement
• 7a37fb2: this type of change lesses the need for 4f64274, in general
• e871a9a: i gave up here, and skipped the 4 failing tests on eslint 4. For posterity, here's the hidden lockfile diff from when i couldn't reproduce the failures, and when i could:

diff --git a/before.json b/after.json
index 060d9faa..f4548e6b 100644
--- a/before.json
+++ b/after.json
@@ -22,17 +22,6 @@
         "trim-right": "^1.0.1"
       }
     },
-    "node_modules/@babel/generator/node_modules/jsesc": {
-      "version": "2.5.2",
-      "dev": true,
-      "license": "MIT",
-      "bin": {
-        "jsesc": "bin/jsesc"
-      },
-      "engines": {
-        "node": ">=4"
-      }
-    },
     "node_modules/@babel/helper-function-name": {
       "version": "7.0.0-beta.44",
       "dev": true,
@@ -162,14 +151,6 @@
         "ms": "^2.1.1"
       }
     },
-    "node_modules/@babel/traverse/node_modules/globals": {
-      "version": "11.12.0",
-      "dev": true,
-      "license": "MIT",
-      "engines": {
-        "node": ">=4"
-      }
-    },
     "node_modules/@babel/traverse/node_modules/ms": {
       "version": "2.1.3",
       "dev": true,
@@ -185,14 +166,6 @@
         "to-fast-properties": "^2.0.0"
       }
     },
-    "node_modules/@babel/types/node_modules/to-fast-properties": {
-      "version": "2.0.0",
-      "dev": true,
-      "license": "MIT",
-      "engines": {
-        "node": ">=4"
-      }
-    },
     "node_modules/@eslint/import-test-order-redirect-scoped": {
       "resolved": "tests/files/order-redirect-scoped",
       "link": true
@@ -326,6 +299,18 @@
         }
       }
     },
+    "node_modules/@typescript-eslint/typescript-estree/node_modules/lru-cache": {
+      "version": "6.0.0",
+      "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-6.0.0.tgz",
+      "integrity": "sha512-Jo6dJ04CmSjuznwJSS3pUeWmd/H0ffTlkXXgwZi+eq1UCmqQwCh+eLsYOYCwY991i2Fah4h1BEMCx4qThGbsiA==",
+      "dev": true,
+      "dependencies": {
+        "yallist": "^4.0.0"
+      },
+      "engines": {
+        "node": ">=10"
+      }
+    },
     "node_modules/@typescript-eslint/typescript-estree/node_modules/ms": {
       "version": "2.1.2",
       "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.2.tgz",
@@ -347,6 +332,12 @@
         "node": ">=10"
       }
     },
+    "node_modules/@typescript-eslint/typescript-estree/node_modules/yallist": {
+      "version": "4.0.0",
+      "resolved": "https://registry.npmjs.org/yallist/-/yallist-4.0.0.tgz",
+      "integrity": "sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A==",
+      "dev": true
+    },
     "node_modules/@typescript-eslint/visitor-keys": {
       "version": "3.10.1",
       "resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-3.10.1.tgz",
@@ -688,7 +679,6 @@
     },
     "node_modules/babel-eslint": {
       "version": "8.2.6",
-      "deprecated": "babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.",
       "dev": true,
       "license": "MIT",
       "dependencies": {
@@ -741,6 +731,14 @@
         "trim-right": "^1.0.1"
       }
     },
+    "node_modules/babel-generator/node_modules/jsesc": {
+      "version": "1.3.0",
+      "dev": true,
+      "license": "MIT",
+      "bin": {
+        "jsesc": "bin/jsesc"
+      }
+    },
     "node_modules/babel-helper-call-delegate": {
       "version": "6.24.1",
       "dev": true,
@@ -916,11 +914,6 @@
         "regenerator-runtime": "^0.10.5"
       }
     },
-    "node_modules/babel-polyfill/node_modules/regenerator-runtime": {
-      "version": "0.10.5",
-      "dev": true,
-      "license": "MIT"
-    },
     "node_modules/babel-preset-es2015-argon": {
       "version": "0.1.0",
       "dev": true,
@@ -965,6 +958,11 @@
         "regenerator-runtime": "^0.11.0"
       }
     },
+    "node_modules/babel-runtime/node_modules/regenerator-runtime": {
+      "version": "0.11.1",
+      "dev": true,
+      "license": "MIT"
+    },
     "node_modules/babel-template": {
       "version": "6.26.0",
       "dev": true,
@@ -993,6 +991,14 @@
         "lodash": "^4.17.4"
       }
     },
+    "node_modules/babel-traverse/node_modules/globals": {
+      "version": "9.18.0",
+      "dev": true,
+      "license": "MIT",
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/babel-types": {
       "version": "6.26.0",
       "dev": true,
@@ -1004,6 +1010,14 @@
         "to-fast-properties": "^1.0.3"
       }
     },
+    "node_modules/babel-types/node_modules/to-fast-properties": {
+      "version": "1.0.3",
+      "dev": true,
+      "license": "MIT",
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/babylon": {
       "version": "6.18.0",
       "dev": true,
@@ -1046,44 +1060,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/base/node_modules/is-accessor-descriptor": {
-      "version": "1.0.0",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^6.0.0"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/base/node_modules/is-data-descriptor": {
-      "version": "1.0.0",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^6.0.0"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/base/node_modules/is-descriptor": {
-      "version": "1.0.2",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "is-accessor-descriptor": "^1.0.0",
-        "is-data-descriptor": "^1.0.0",
-        "kind-of": "^6.0.2"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/base/node_modules/isobject": {
       "version": "3.0.1",
       "dev": true,
@@ -1093,15 +1069,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/base/node_modules/kind-of": {
-      "version": "6.0.3",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/bcrypt-pbkdf": {
       "version": "1.0.2",
       "dev": true,
@@ -1339,6 +1306,53 @@
         "node": ">=0.10.0"
       }
     },
+    "node_modules/class-utils/node_modules/is-accessor-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/class-utils/node_modules/is-data-descriptor": {
+      "version": "0.1.4",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/class-utils/node_modules/is-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "is-accessor-descriptor": "^0.1.6",
+        "is-data-descriptor": "^0.1.4",
+        "kind-of": "^5.0.0"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/class-utils/node_modules/is-descriptor/node_modules/kind-of": {
+      "version": "5.1.0",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/class-utils/node_modules/isobject": {
       "version": "3.0.1",
       "dev": true,
@@ -1465,7 +1479,6 @@
     },
     "node_modules/core-js": {
       "version": "2.6.12",
-      "deprecated": "core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.",
       "dev": true,
       "hasInstallScript": true,
       "license": "MIT"
@@ -1518,20 +1531,6 @@
         "which": "^1.2.9"
       }
     },
-    "node_modules/cross-spawn/node_modules/lru-cache": {
-      "version": "4.1.5",
-      "dev": true,
-      "license": "ISC",
-      "dependencies": {
-        "pseudomap": "^1.0.2",
-        "yallist": "^2.1.2"
-      }
-    },
-    "node_modules/cross-spawn/node_modules/yallist": {
-      "version": "2.1.2",
-      "dev": true,
-      "license": "ISC"
-    },
     "node_modules/dashdash": {
       "version": "1.14.1",
       "dev": true,
@@ -1598,44 +1597,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/define-property/node_modules/is-accessor-descriptor": {
-      "version": "1.0.0",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^6.0.0"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/define-property/node_modules/is-data-descriptor": {
-      "version": "1.0.0",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^6.0.0"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/define-property/node_modules/is-descriptor": {
-      "version": "1.0.2",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "is-accessor-descriptor": "^1.0.0",
-        "is-data-descriptor": "^1.0.0",
-        "kind-of": "^6.0.2"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/define-property/node_modules/isobject": {
       "version": "3.0.1",
       "dev": true,
@@ -1645,15 +1606,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/define-property/node_modules/kind-of": {
-      "version": "6.0.3",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/delayed-stream": {
       "version": "1.0.0",
       "dev": true,
@@ -1817,8 +1769,9 @@
     },
     "node_modules/eslint-import-resolver-typescript": {
       "version": "1.0.2",
+      "resolved": "https://registry.npmjs.org/eslint-import-resolver-typescript/-/eslint-import-resolver-typescript-1.0.2.tgz",
+      "integrity": "sha512-cO0H244gGEdekOhWmF2hq9nsqovGzSDwAMjfpSJf4u33SmuFNmMhU/+N6A7y9dsIgV17ETzXjjRne9sec1CWxA==",
       "dev": true,
-      "license": "ISC",
       "dependencies": {
         "resolve": "^1.4.0"
       }
@@ -2006,14 +1959,6 @@
       "dev": true,
       "license": "MIT"
     },
-    "node_modules/eslint/node_modules/globals": {
-      "version": "11.12.0",
-      "dev": true,
-      "license": "MIT",
-      "engines": {
-        "node": ">=4"
-      }
-    },
     "node_modules/eslint/node_modules/json-schema-traverse": {
       "version": "0.3.1",
       "dev": true,
@@ -2379,7 +2324,6 @@
     },
     "node_modules/formatio": {
       "version": "1.2.0",
-      "deprecated": "This package is unmaintained. Use @sinonjs/formatio instead",
       "dev": true,
       "license": "BSD-3-Clause",
       "dependencies": {
@@ -2418,7 +2362,6 @@
     },
     "node_modules/fsevents": {
       "version": "1.2.13",
-      "deprecated": "fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.",
       "dev": true,
       "hasInstallScript": true,
       "license": "MIT",
@@ -2558,11 +2501,11 @@
       }
     },
     "node_modules/globals": {
-      "version": "9.18.0",
+      "version": "11.12.0",
       "dev": true,
       "license": "MIT",
       "engines": {
-        "node": ">=0.10.0"
+        "node": ">=4"
       }
     },
     "node_modules/graceful-fs": {
@@ -2589,7 +2532,6 @@
     },
     "node_modules/har-validator": {
       "version": "5.1.5",
-      "deprecated": "this library is no longer supported",
       "dev": true,
       "license": "MIT",
       "dependencies": {
@@ -2630,7 +2572,7 @@
       }
     },
     "node_modules/has-symbols": {
-      "version": "1.0.1",
+      "version": "1.0.2",
       "license": "MIT",
       "engines": {
         "node": ">= 0.4"
@@ -2882,17 +2824,26 @@
       }
     },
     "node_modules/is-accessor-descriptor": {
-      "version": "0.1.6",
+      "version": "1.0.0",
       "dev": true,
       "license": "MIT",
       "optional": true,
       "dependencies": {
-        "kind-of": "^3.0.2"
+        "kind-of": "^6.0.0"
       },
       "engines": {
         "node": ">=0.10.0"
       }
     },
+    "node_modules/is-accessor-descriptor/node_modules/kind-of": {
+      "version": "6.0.3",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/is-arrayish": {
       "version": "0.2.1",
       "license": "MIT"
@@ -2929,17 +2880,26 @@
       "license": "MIT"
     },
     "node_modules/is-data-descriptor": {
-      "version": "0.1.4",
+      "version": "1.0.0",
       "dev": true,
       "license": "MIT",
       "optional": true,
       "dependencies": {
-        "kind-of": "^3.0.2"
+        "kind-of": "^6.0.0"
       },
       "engines": {
         "node": ">=0.10.0"
       }
     },
+    "node_modules/is-data-descriptor/node_modules/kind-of": {
+      "version": "6.0.3",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/is-date-object": {
       "version": "1.0.2",
       "license": "MIT",
@@ -2951,21 +2911,21 @@
       }
     },
     "node_modules/is-descriptor": {
-      "version": "0.1.6",
+      "version": "1.0.2",
       "dev": true,
       "license": "MIT",
       "optional": true,
       "dependencies": {
-        "is-accessor-descriptor": "^0.1.6",
-        "is-data-descriptor": "^0.1.4",
-        "kind-of": "^5.0.0"
+        "is-accessor-descriptor": "^1.0.0",
+        "is-data-descriptor": "^1.0.0",
+        "kind-of": "^6.0.2"
       },
       "engines": {
         "node": ">=0.10.0"
       }
     },
     "node_modules/is-descriptor/node_modules/kind-of": {
-      "version": "5.1.0",
+      "version": "6.0.3",
       "dev": true,
       "license": "MIT",
       "optional": true,
@@ -3233,11 +3193,14 @@
       "license": "MIT"
     },
     "node_modules/jsesc": {
-      "version": "1.3.0",
+      "version": "2.5.2",
       "dev": true,
       "license": "MIT",
       "bin": {
         "jsesc": "bin/jsesc"
+      },
+      "engines": {
+        "node": ">=4"
       }
     },
     "node_modules/json-schema": {
@@ -3261,7 +3224,6 @@
     },
     "node_modules/json3": {
       "version": "3.3.2",
-      "deprecated": "Please use the native JSON object instead of JSON 3",
       "dev": true
     },
     "node_modules/json5": {
@@ -3433,7 +3395,6 @@
     },
     "node_modules/lodash.isarray": {
       "version": "4.0.0",
-      "deprecated": "This package is deprecated. Use Array.isArray.",
       "dev": true,
       "license": "MIT"
     },
@@ -3482,15 +3443,12 @@
       }
     },
     "node_modules/lru-cache": {
-      "version": "6.0.0",
-      "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-6.0.0.tgz",
-      "integrity": "sha512-Jo6dJ04CmSjuznwJSS3pUeWmd/H0ffTlkXXgwZi+eq1UCmqQwCh+eLsYOYCwY991i2Fah4h1BEMCx4qThGbsiA==",
+      "version": "4.1.5",
       "dev": true,
+      "license": "ISC",
       "dependencies": {
-        "yallist": "^4.0.0"
-      },
-      "engines": {
-        "node": ">=10"
+        "pseudomap": "^1.0.2",
+        "yallist": "^2.1.2"
       }
     },
     "node_modules/map-cache": {
@@ -3731,7 +3689,6 @@
     },
     "node_modules/mocha/node_modules/mkdirp": {
       "version": "0.5.1",
-      "deprecated": "Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)",
       "dev": true,
       "license": "MIT",
       "dependencies": {
@@ -7563,6 +7520,53 @@
         "node": ">=0.10.0"
       }
     },
+    "node_modules/object-copy/node_modules/is-accessor-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/object-copy/node_modules/is-data-descriptor": {
+      "version": "0.1.4",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/object-copy/node_modules/is-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "is-accessor-descriptor": "^0.1.6",
+        "is-data-descriptor": "^0.1.4",
+        "kind-of": "^5.0.0"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/object-copy/node_modules/is-descriptor/node_modules/kind-of": {
+      "version": "5.1.0",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/object-inspect": {
       "version": "1.9.0",
       "license": "MIT",
@@ -8180,54 +8184,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/readdirp/node_modules/expand-brackets/node_modules/is-accessor-descriptor": {
-      "version": "0.1.6",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^3.0.2"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/readdirp/node_modules/expand-brackets/node_modules/is-accessor-descriptor/node_modules/kind-of": {
-      "version": "3.2.2",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "is-buffer": "^1.1.5"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/readdirp/node_modules/expand-brackets/node_modules/is-data-descriptor": {
-      "version": "0.1.4",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^3.0.2"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/readdirp/node_modules/expand-brackets/node_modules/is-data-descriptor/node_modules/kind-of": {
-      "version": "3.2.2",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "is-buffer": "^1.1.5"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/readdirp/node_modules/expand-brackets/node_modules/is-descriptor": {
       "version": "0.1.6",
       "dev": true,
@@ -8322,38 +8278,48 @@
       }
     },
     "node_modules/readdirp/node_modules/is-accessor-descriptor": {
-      "version": "1.0.0",
+      "version": "0.1.6",
       "dev": true,
       "license": "MIT",
       "optional": true,
       "dependencies": {
-        "kind-of": "^6.0.0"
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/readdirp/node_modules/is-accessor-descriptor/node_modules/kind-of": {
+      "version": "3.2.2",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "is-buffer": "^1.1.5"
       },
       "engines": {
         "node": ">=0.10.0"
       }
     },
     "node_modules/readdirp/node_modules/is-data-descriptor": {
-      "version": "1.0.0",
+      "version": "0.1.4",
       "dev": true,
       "license": "MIT",
       "optional": true,
       "dependencies": {
-        "kind-of": "^6.0.0"
+        "kind-of": "^3.0.2"
       },
       "engines": {
         "node": ">=0.10.0"
       }
     },
-    "node_modules/readdirp/node_modules/is-descriptor": {
-      "version": "1.0.2",
+    "node_modules/readdirp/node_modules/is-data-descriptor/node_modules/kind-of": {
+      "version": "3.2.2",
       "dev": true,
       "license": "MIT",
       "optional": true,
       "dependencies": {
-        "is-accessor-descriptor": "^1.0.0",
-        "is-data-descriptor": "^1.0.0",
-        "kind-of": "^6.0.2"
+        "is-buffer": "^1.1.5"
       },
       "engines": {
         "node": ">=0.10.0"
@@ -8442,7 +8408,7 @@
       "license": "MIT"
     },
     "node_modules/regenerator-runtime": {
-      "version": "0.11.1",
+      "version": "0.10.5",
       "dev": true,
       "license": "MIT"
     },
@@ -8545,7 +8511,6 @@
     },
     "node_modules/request": {
       "version": "2.88.2",
-      "deprecated": "request has been deprecated, see https://github.com/request/request/issues/3142",
       "dev": true,
       "license": "Apache-2.0",
       "dependencies": {
@@ -8612,7 +8577,6 @@
     },
     "node_modules/resolve-url": {
       "version": "0.2.1",
-      "deprecated": "https://github.com/lydell/resolve-url#deprecated",
       "dev": true,
       "license": "MIT",
       "optional": true
@@ -8699,7 +8663,6 @@
     },
     "node_modules/samsam": {
       "version": "1.3.0",
-      "deprecated": "This package has been deprecated in favour of @sinonjs/samsam",
       "dev": true,
       "license": "BSD-3-Clause"
     },
@@ -8844,44 +8807,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/snapdragon-node/node_modules/is-accessor-descriptor": {
-      "version": "1.0.0",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^6.0.0"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/snapdragon-node/node_modules/is-data-descriptor": {
-      "version": "1.0.0",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "kind-of": "^6.0.0"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
-    "node_modules/snapdragon-node/node_modules/is-descriptor": {
-      "version": "1.0.2",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "dependencies": {
-        "is-accessor-descriptor": "^1.0.0",
-        "is-data-descriptor": "^1.0.0",
-        "kind-of": "^6.0.2"
-      },
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/snapdragon-node/node_modules/isobject": {
       "version": "3.0.1",
       "dev": true,
@@ -8891,15 +8816,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/snapdragon-node/node_modules/kind-of": {
-      "version": "6.0.3",
-      "dev": true,
-      "license": "MIT",
-      "optional": true,
-      "engines": {
-        "node": ">=0.10.0"
-      }
-    },
     "node_modules/snapdragon-util": {
       "version": "3.0.1",
       "dev": true,
@@ -8936,6 +8852,53 @@
         "node": ">=0.10.0"
       }
     },
+    "node_modules/snapdragon/node_modules/is-accessor-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/snapdragon/node_modules/is-data-descriptor": {
+      "version": "0.1.4",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/snapdragon/node_modules/is-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "is-accessor-descriptor": "^0.1.6",
+        "is-data-descriptor": "^0.1.4",
+        "kind-of": "^5.0.0"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/snapdragon/node_modules/is-descriptor/node_modules/kind-of": {
+      "version": "5.1.0",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/source-map": {
       "version": "0.5.7",
       "dev": true,
@@ -9027,11 +8990,6 @@
         "safer-buffer": "^2.0.2",
         "tweetnacl": "~0.14.0"
       },
-      "bin": {
-        "sshpk-conv": "bin/sshpk-conv",
-        "sshpk-sign": "bin/sshpk-sign",
-        "sshpk-verify": "bin/sshpk-verify"
-      },
       "engines": {
         "node": ">=0.10.0"
       }
@@ -9061,6 +9019,53 @@
         "node": ">=0.10.0"
       }
     },
+    "node_modules/static-extend/node_modules/is-accessor-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/static-extend/node_modules/is-data-descriptor": {
+      "version": "0.1.4",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "kind-of": "^3.0.2"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/static-extend/node_modules/is-descriptor": {
+      "version": "0.1.6",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "dependencies": {
+        "is-accessor-descriptor": "^0.1.6",
+        "is-data-descriptor": "^0.1.4",
+        "kind-of": "^5.0.0"
+      },
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
+    "node_modules/static-extend/node_modules/is-descriptor/node_modules/kind-of": {
+      "version": "5.1.0",
+      "dev": true,
+      "license": "MIT",
+      "optional": true,
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/string_decoder": {
       "version": "1.1.1",
       "dev": true,
@@ -9334,7 +9339,6 @@
     },
     "node_modules/text-encoding": {
       "version": "0.6.4",
-      "deprecated": "no longer maintained",
       "dev": true,
       "license": "Unlicense"
     },
@@ -9360,11 +9364,11 @@
       }
     },
     "node_modules/to-fast-properties": {
-      "version": "1.0.3",
+      "version": "2.0.0",
       "dev": true,
       "license": "MIT",
       "engines": {
-        "node": ">=0.10.0"
+        "node": ">=4"
       }
     },
     "node_modules/to-object-path": {
@@ -9534,7 +9538,6 @@
     },
     "node_modules/typescript-eslint-parser": {
       "version": "22.0.0",
-      "deprecated": "Deprecated: Use @typescript-eslint/parser instead",
       "dev": true,
       "license": "BSD-2-Clause",
       "dependencies": {
@@ -9564,7 +9567,6 @@
     },
     "node_modules/typescript-estree": {
       "version": "18.0.0",
-      "deprecated": "This package was moved to @typescript-eslint/typescript-estree, please install the latest version from there instead",
       "dev": true,
       "license": "BSD-2-Clause",
       "dependencies": {
@@ -9668,7 +9670,6 @@
     },
     "node_modules/urix": {
       "version": "0.1.0",
-      "deprecated": "Please see https://github.com/lydell/urix#deprecated",
       "dev": true,
       "license": "MIT",
       "optional": true
@@ -9805,10 +9806,9 @@
       }
     },
     "node_modules/yallist": {
-      "version": "4.0.0",
-      "resolved": "https://registry.npmjs.org/yallist/-/yallist-4.0.0.tgz",
-      "integrity": "sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A==",
-      "dev": true
+      "version": "2.1.2",
+      "dev": true,
+      "license": "ISC"
     },
     "resolvers/webpack": {
       "name": "eslint-import-resolver-webpack",

[ljharb]

Looks like tests are still failing on PRs despite passing on master.