scripts/pdg.sh: also run analysis #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
reviewed
Jun 30, 2023
kkysen
reviewed
Jun 30, 2023
kkysen
reviewed
Jun 30, 2023
kkysen
reviewed
Jun 30, 2023
Comment on lines
+101
to
+96
| "-C" \ | ||
| "metadata=4095517b1921578c" \ |
There was a problem hiding this comment.
Do we need this? What's that hash for? It looks fragile.
kkysen
reviewed
Jun 30, 2023
| "-C" \ | ||
| "metadata=4095517b1921578c" \ | ||
| "-L" "dependency=${deps_dir}" \ | ||
| "--extern" "libc=${libc_dep}" \ |
There was a problem hiding this comment.
We also need c2rust_bitfields.
kkysen
reviewed
Jun 30, 2023
kkysen
reviewed
Jul 12, 2023
There was a problem hiding this comment.
I think it would be better to move these additions to Rust code in c2rust_pdg::tests rather than adding to this shell script, even if that's not their eventual location once c2rust-analyze gets cargo-wrapped. Right now, that's the canonical invocation of c2rust-instrument that is run in CI tests. scripts/pdg.sh isn't used regularly anymore and I'm not sure if it's fully up-to-date (I'd prefer to remove it entirely). This way, this end-to-end static + runtime analysis will be tested in CI.
this is fairly hacky and best-effort, but until c2rust-analyze is a rustc wrapper for cargo, it's hard to do better, and this avoids duplicating the work of figuring out these hacks
fw-immunant
force-pushed
the
fw/pdg.sh-analyze
branch
from
4da6b95
to
e71c2b3
Compare
|
Superseded by #1069. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly hacky and best-effort, but until c2rust-analyze is a rustc wrapper for cargo, it's hard to do better, and this avoids duplicating the work of figuring out these hacks.
To see it in action:
./scripts/pdg.sh analysis/tests/minimal