Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate use of PDG from dynamic analysis in static analysis #1069

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

fw-immunant
Copy link
Contributor

Turns out we need to pass the profile flags twice: once for the outer invocation of cargo itself and once for the inner invocation of our cargo wrapper. This, along with the --feature flags for the inner crate and the addition of an optional dependency, make things work with the same crate ID.

@spernsteiner
Copy link
Collaborator

Seems unfortunate that the user's project needs this extra c2rust-analysis-rt dependency that they'll never use in normal builds. How does c2rust-instrument go about injecting this dependency? Could c2rust-analyze do the same?

@kkysen
Copy link
Contributor

kkysen commented Mar 25, 2024

Seems unfortunate that the user's project needs this extra c2rust-analysis-rt dependency that they'll never use in normal builds. How does c2rust-instrument go about injecting this dependency? Could c2rust-analyze do the same?

c2rust instrument has an option to add it as an optional dependency automatically.

this was way too painful to plumb and debug for what it ended up being :(
@fw-immunant
Copy link
Contributor Author

Dropped the dependency-adding commit as we actually don't need it as @kkysen indicated.

@fw-immunant fw-immunant merged commit fb37a81 into master Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants