-
Notifications
You must be signed in to change notification settings - Fork 13
Add Eio collector #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2aa8ed to
4f1c1ae
Compare
f5eae04 to
1787d42
Compare
Co-authored-by: Puneeth Chaganti <punchagan@muse-amuse.in>
1787d42 to
94772c7
Compare
|
This should be ready for review when you have availability! |
| build: | ||
| strategy: | ||
| fail-fast: true | ||
| fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to fail fast any more, since we test different packages in different parts of the build matrix.
c-cube
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot! But I think it looks solid. I only have minor qualms, then I'll merge :)
Yes, I'm sorry I wasn't able to break this into smaller bits given my time frame. Tho it was smaller than the first draft at least 😅 Thank you for the review and for catching the issues you noticed! |
|
seems like the package is still dependent on |
|
Fixed now I think! |
|
Thank you! :) |
Closes #51
The primary addition here a collector using a
Cohttp_eioclient to collect signals in programs using Eio. Additional changes include:Cohttp_eios different preferences round networking (defaulting to IPv6).emit1-cottp.ml.Todo