Factor batching logic out of the cohttp-lwt client #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow resuing the batching logic in the Eio client. As a followup, we should refactor the ocurl client to use the same batcher.
c-cube
approved these changes
Jun 30, 2025
Member
c-cube
left a comment
c-cube
left a comment
There was a problem hiding this comment.
I think it's great! There's a couple small nitpicks but this is going to be much nicer (and factored)!
Since we need to traverse the elements added to count up the new size, we can use that pass to add the elements onto our FIFO queue, and then drain the queue in one last pass to reverse. IIUC, this should give us liner complexity of the batch retrieval.
Contributor
Author
|
Thanks for the helpful review! Should be ready for a second look! I've re-tested it against #96 locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow reusing the batching logic in the Eio client. As a followup, we should refactor the ocurl client to use the same batcher.
Most changes here are purely mechanical, and just a matter of relocating the batching logic into its own module. Tho a few small cleanups were added:
Batchlogic is specialized to storing lists of lists its element type, which allows us to move the list flattening logic into the pop logic, rather than having to handle this in the clients. This specialization is justified because this is not a general purpose batching data-structure, but already highly specialized to our particular application.pushfunction that returned a bool, and renamedpush'topush.n_droppedcounter out of the batcher, instead having thepushfunction return a value to report if dropping occurred, which the client can then handle as needed.This PR does not reuse the new
Batchmodule for the ocurl client, but you can see what that would look like in my exploratory branch if your curious :)I have tested this locally against on top of the branch for #96, and the exact same signals are produced.