Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reader.read_row for decoding into caller-provided buffer. #493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    b7d0c06 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add Reader.read_row for decoding into caller-provided buffer.

    `Reader.read_row` is an alternative to `Reader.next_row`.
    
    * `Reader.next_row` is convenient when the caller doesn't want to manage
      their own buffer, and doesn't mind having extended borrows on `Reader`
      to accommodate `Row` data.
    * OTOH the new `Reader.read_row` avoids an extra copy in some scanarios
      which may lead to better runtime performance - see the benchmark
      results below.
    
    The commit results in the followin performance gains seen in the
    recently introduced `row-by-row/128x128-4k-idat` benchmark:
    
    time:   [-16.414% -16.196% -15.969%] (p = 0.00 < 0.05)
    time:   [-15.570% -15.218% -14.856%] (p = 0.00 < 0.05)
    time:   [-16.101% -15.864% -15.629%] (p = 0.00 < 0.05)
    anforowicz committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    03f36ed View commit details
    Browse the repository at this point in the history