Add Reader.read_row for decoding into caller-provided buffer.
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR replaces #421. (This PR can be seen as a non-breaking-change alternative of the other, earlier PR.) |
kornelski
approved these changes
Aug 16, 2024
`Reader.read_row` is an alternative to `Reader.next_row`. * `Reader.next_row` is convenient when the caller doesn't want to manage their own buffer, and doesn't mind having extended borrows on `Reader` to accommodate `Row` data. * OTOH the new `Reader.read_row` avoids an extra copy in some scanarios which may lead to better runtime performance - see the benchmark results below. The commit results in the followin performance gains seen in the recently introduced `row-by-row/128x128-4k-idat` benchmark: time: [-16.414% -16.196% -15.969%] (p = 0.00 < 0.05) time: [-15.570% -15.218% -14.856%] (p = 0.00 < 0.05) time: [-16.101% -15.864% -15.629%] (p = 0.00 < 0.05)
|
There doesn't seem to be any reason not to merge this. @anforowicz could you resolve the conflicts? I'll push the merge button as soon as that's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Reader.read_rowfor decoding into caller-provided buffer.Reader.read_rowis an alternative toReader.next_row.Reader.next_rowis convenient when the caller doesn't want to managetheir own buffer, and doesn't mind having extended borrows on
Readerto accommodate
Rowdata.Reader.read_rowavoids an extra copy in some scanarioswhich may lead to better runtime performance - see the benchmark
results below.
The PR adds a
row-by-row/128x128-4k-idatbenchmark (initially based onReader.next_rowwhich requires an extra copy). Using the newReader.read_rowresults in the following performance gains in thebenchmark:
time: [-16.414% -16.196% -15.969%] (p = 0.00 < 0.05)
time: [-15.570% -15.218% -14.856%] (p = 0.00 < 0.05)
time: [-16.101% -15.864% -15.629%] (p = 0.00 < 0.05)