Skip to content

IIA-2518 Display Semantic name with fallback #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhharsh13 merged 5 commits into from
Aug 1, 2025
Merged

IIA-2518 Display Semantic name with fallback #618

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f11fe70
Update version to start feature: IIA-2518-Semantic-display-names
Aug 1, 2025
b32c279
Display Semantic names with fallback
Aug 1, 2025
a13260a
Update version to finish feature: IIA-2518-Semantic-display-names
Aug 1, 2025
826006c
code reusability
Aug 1, 2025
1ab241f
Merge branch 'main' into feature/finished/IIA-2518-Semantic-display-n…
bhharsh13 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions kview/src/main/java/dev/ikm/komet/kview/mvvm/view/navigation/PatternNavEntryController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import dev.ikm.komet.kview.controls.KometIcon;
import dev.ikm.komet.kview.events.genediting.MakeGenEditingWindowEvent;
import dev.ikm.komet.kview.events.pattern.MakePatternWindowEvent;
import dev.ikm.tinkar.coordinate.language.calculator.LanguageCalculator;
import dev.ikm.tinkar.coordinate.view.calculator.ViewCalculator;
import dev.ikm.tinkar.entity.EntityService;
import dev.ikm.tinkar.entity.SemanticEntity;
Expand Down Expand Up @@ -179,17 +180,18 @@ private void setupListView() {
});

ViewProperties viewProperties = instancesViewModel.getPropertyValue(VIEW_PROPERTIES);
Function<Integer, String> fetchDescriptionByNid = (nid -> {
Function<Integer, String> fetchDescriptionByNid = nid -> {
// Reference Component in Pattern
String descr = "";
if (EntityService.get().getEntity(nid).get() instanceof SemanticEntity semanticEntity) {
EntityFacade refComponent = EntityService.get().getEntity(semanticEntity.referencedComponentNid()).get();
PatternFacade patternFacade = semanticEntity.pattern().toProxy();
descr = viewProperties.calculator().languageCalculator().getDescriptionText(refComponent.nid()).get()+" ";
descr += viewProperties.calculator().languageCalculator().getDescriptionTextOrNid(patternFacade.nid());
LanguageCalculator languageCalculator = viewProperties.calculator().languageCalculator();
descr = languageCalculator.getPreferredDescriptionTextWithFallbackOrNid(refComponent.nid())+" ";
descr += languageCalculator.getPreferredDescriptionTextWithFallbackOrNid(patternFacade.nid());
}
return descr;
});
};
Function<EntityFacade, String> fetchDescriptionByFacade = (facade -> viewProperties.calculator().getPreferredDescriptionTextWithFallbackOrNid(facade));
// set the cell factory for each pattern's instances list
patternInstancesListView.setCellFactory(_ -> new PatternSemanticListCell(fetchDescriptionByNid, fetchDescriptionByFacade, viewProperties));
Expand Down