IIA-2518 Display Semantic name with fallback #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhharsh13
requested review from
carldea,
dholubek,
dukke,
jdsmithsos and
swaroopsalvi
jdsmithsos
requested changes
Aug 1, 2025
| PatternFacade patternFacade = semanticEntity.pattern().toProxy(); | ||
| descr = viewProperties.calculator().languageCalculator().getDescriptionText(refComponent.nid()).get()+" "; | ||
| descr += viewProperties.calculator().languageCalculator().getDescriptionTextOrNid(patternFacade.nid()); | ||
| descr = viewProperties.calculator().languageCalculator().getPreferredDescriptionTextWithFallbackOrNid(refComponent.nid())+" "; |
Contributor
There was a problem hiding this comment.
I know that the code was like this before, but request a slight change to get the languageCalculator.
Just call viewProperties.calculator().langaugeCalculator() one time, store in variable.
Use that variable to call the getPreferredDescriptionTextWithFallbackOrNid().
Contributor
Author
There was a problem hiding this comment.
Assigned the viewProperties.calculator().langaugeCalculator() to a variable for reusability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue to display Semantic name with fallback - https://ikmdev.atlassian.net/browse/IIA-2518
Validated the changes on local and "java.util.NoSuchElementException: No value present" is fixed.
Before Change:
After Change:
No Exception thrown