Skip to content

Deleting unnecessary while statement #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Deleting unnecessary while statement #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7340511
Deleting unnecessary while statement
Beomyeong May 30, 2025
47a133e
Deleting unnecessary line
Beomyeong Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/geometry/java/us/ihmc/euclid/geometry/tools/EuclidGeometryPolygonTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,10 @@ public static int inPlaceGiftWrapConvexHull2D(List<? extends Point2DReadOnly> ve
return numberOfVertices;
}

while (candidateIndex < numberOfVertices && lastHullVertexIndex >= 1
&& isCandidatePointCollinearInOppositeDirectionWithTheFirstPoint(lastHullVertex,
vertices.get(lastHullVertexIndex- 1),
candidateVertex,
EPSILON))
while (lastHullVertexIndex >= 1 && isCandidatePointCollinearInOppositeDirectionWithTheFirstPoint(lastHullVertex,
vertices.get(lastHullVertexIndex- 1),
candidateVertex,
EPSILON))
{ // The next candidate vertex isn't valid because it's collinear, but may be valid for a future point, so we want to keep it in scope.
candidateIndex++;

Expand Down
Loading