Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0.10 #8048

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Version 1.0.10 #8048

merged 2 commits into from
Nov 18, 2023

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Nov 17, 2023 •
edited
Loading

Getting better.

For reviewers: please ignore script/packaging/common/fheroes2.metainfo.xml as it is autogenerated from changelog.txt file.

@ihhub
Version 1.0.10
b94d028 
Getting better.
@ihhub ihhub added the improvement New feature, request or improvement label Nov 17, 2023
@ihhub ihhub added this to the 1.0.10 milestone Nov 17, 2023
@ihhub ihhub self-assigned this Nov 17, 2023
github-actions[bot]
github-actions bot reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/system/version.h Show resolved Hide resolved
@Mr-Bajs
Copy link
Contributor

Mr-Bajs commented Nov 17, 2023 •
edited
Loading

Awesome

Isn't it better to slim the changelog for improved readability for the next releases?

Example the lines
update Russian translation
update Vietnamese translation
update German translation
update Swedish translation
update Hungarian translation

could instead be read as one line as
updated Russian, Hungarian, Swedish, Vietnamese and German translations.

@ihhub
Copy link
Owner Author

ihhub commented Nov 17, 2023

@Mr-Bajs , we always provide a list of major changes for each release.

zenseii
zenseii requested changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ihhub. I left some comments. Please have a look.

changelog.txt Outdated Show resolved Hide resolved
changelog.txt Outdated Show resolved Hide resolved
changelog.txt Outdated Show resolved Hide resolved
changelog.txt Outdated Show resolved Hide resolved
@ihhub ihhub requested a review from zenseii November 17, 2023 12:47
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ihhub ihhub merged commit d443175 into master Nov 18, 2023
21 checks passed
@ihhub ihhub deleted the version-1.0.10 branch November 18, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Districh-ru Districh-ru Districh-ru approved these changes

@zenseii zenseii zenseii approved these changes

Assignees

@ihhub ihhub

Labels
improvement New feature, request or improvement
Projects
None yet
Milestone
1.0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@ihhub @Mr-Bajs @zenseii @Districh-ru