Skip to content

fix: return error when imported module is not wasm #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2021
Merged

fix: return error when imported module is not wasm #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bf8ae2
Add error message
lumtis Mar 11, 2021
aaf53f6
Merge branch 'develop' into fix/import-only-wasm
lumtis Mar 11, 2021
93d1e4f
Add nolint
lumtis Mar 11, 2021
42f070f
Merge branch 'fix/import-only-wasm' of https://github.com/tendermint/…
lumtis Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions starport/services/chain/grpcweb_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ func newGRPCWebProxyHandler(grpcServerAddress string) (*grpc.ClientConn, http.Ha
grpcopts := []grpc.DialOption{
grpc.WithInsecure(),
// TODO: https://github.com/tendermint/starport/issues/562
//nolint:staticcheck
grpc.WithCodec(proxy.Codec()),
}

Expand All @@ -41,6 +42,7 @@ func newGRPCWebProxyHandler(grpcServerAddress string) (*grpc.ClientConn, http.Ha
// Server with logging and monitoring enabled.
grpcserver := grpc.NewServer(
// TODO: https://github.com/tendermint/starport/issues/562
//nolint:staticcheck
grpc.CustomCodec(proxy.Codec()), // needed for proxy to function.
grpc.UnknownServiceHandler(proxy.TransparentHandler(director)),
grpc_middleware.WithUnaryServerChain(),
Expand Down
5 changes: 5 additions & 0 deletions starport/services/scaffolder/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ func (s *Scaffolder) CreateModule(moduleName string, options ...ModuleCreationOp

// ImportModule imports specified module with name to the scaffolded app.
func (s *Scaffolder) ImportModule(name string) error {
// Only wasm is currently supported
if name != "wasm" {
return errors.New("module cannot be imported. Supported module: wasm")
}

version, err := s.version()
if err != nil {
return err
Expand Down