Skip to content

fix: return error when imported module is not wasm #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2021
Merged

fix: return error when imported module is not wasm #836

merged 4 commits into from
Mar 11, 2021

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Mar 11, 2021

starport module import foo

returns:

module cannot be imported. Supported module: wasm

@lumtis lumtis requested review from fadeev and ilgooz as code owners March 11, 2021 08:53
@lumtis lumtis linked an issue Mar 11, 2021 that may be closed by this pull request
fix: starport module import wasm #775
Closed
ilgooz
ilgooz reviewed Mar 11, 2021
View reviewed changes
ilgooz
ilgooz previously approved these changes Mar 11, 2021
View reviewed changes
fadeev
fadeev previously approved these changes Mar 11, 2021
View reviewed changes
@lumtis lumtis dismissed stale reviews from fadeev and ilgooz via 42f070f March 11, 2021 10:07
@lumtis
Copy link
Contributor Author

lumtis commented Mar 11, 2021

@ilgooz Added nolint back since Lint was failing

I check if #562 can now be addressed

@lumtis lumtis requested review from fadeev and ilgooz March 11, 2021 10:14
@ilgooz ilgooz merged commit 74f48ea into develop Mar 11, 2021
@ilgooz ilgooz deleted the fix/import-only-wasm branch March 11, 2021 10:26
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix: return error when imported module is not wasm (ignite#836)
7945502 
* Add error message

* Add nolint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilgooz ilgooz ilgooz approved these changes

+1 more reviewer

@fadeev fadeev fadeev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: starport module import wasm

4 participants

@lumtis @fadeev @ilgooz