refactor: rename server fields in config #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know you know, but just making sure we don't change |
|
Can we have |
ilgooz
requested changes
Mar 11, 2021
starport/services/chain/serve.go
Outdated
|
|
||
| host := conf.Faucet.Host | ||
| if conf.Faucet.Port != 0 { | ||
| host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) |
There was a problem hiding this comment.
Suggested change
| host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) | |
| host = fmt.Sprintf(":%d", conf.Faucet.Port) |
Let's follow the same pattern here:
https://github.com/tendermint/starport/blob/e94b428a1c4856cf101463d9afc8d8d1cec632a8/starport/chainconf/config.go#L24-L30
starport/services/chain/serve.go
Outdated
| fmt.Fprintf(c.stdLog(logStarport).out, "🌍 Running a Cosmos '%[1]v' app with Tendermint at %s.\n", c.app.Name, xurl.HTTP(conf.Host.RPC)) | ||
| fmt.Fprintf(c.stdLog(logStarport).out, "🌍 Running a server at %s (LCD)\n", xurl.HTTP(conf.Host.API)) | ||
|
|
||
| host := conf.Faucet.Host |
There was a problem hiding this comment.
Can we move this part related to determining address for the faucet to starporconf.FaucetHost(), and reuse it here?
starport/services/chain/serve.go
Outdated
| return err | ||
| } | ||
|
|
||
| host := conf.Faucet.Host |
There was a problem hiding this comment.
Can we move this part related to determining address for the faucet to starporconf.FaucetHost(), and reuse it here?
ilgooz
approved these changes
Mar 11, 2021
fadeev
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.