Skip to content

Conversation

@toschdev
Copy link
Contributor

@toschdev toschdev commented Mar 9, 2021

The IBC Hello World tutorial describes packets that are sent via two blockchains with a basic blog module.

Thanks for writing Concept and Code @ltacker

Copy link

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial. I enjoyed it. I did not run it, for time savings today. Please teach me more about the technology, and I can teach us (and learn together) about how we want the standards and styles to be applied for tutorials. I put a LOT of edits. You can commit the suggestions that you agree with, and let's talk through any questions.

@toschdev
Copy link
Contributor Author

This is great @barriebyron ! Thanks for all the feedback and bringing in the standards ⭐️

Copy link

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tutorial is looking so awesome. The intro bits can probably be tweaked a bit more, I can't envision the entire tutorial yet. YAY well done

@fadeev
Copy link
Contributor

fadeev commented Mar 10, 2021

Added comments based on renaming of servers prop to host: ignite/cli#833

Copy link

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so awesome now!

@toschdev toschdev marked this pull request as ready for review March 11, 2021 09:34
@toschdev
Copy link
Contributor Author

Thanks for the review @fadeev
Integrated the suggested changes, left with 2-3 questions

@fadeev
Copy link
Contributor

fadeev commented Mar 11, 2021

I still think we should use the compact notation for hosts, easier to type:

host:
  rpc: ":26659"
  p2p: ":26658"
  prof: ":6061"
  grpc: ":9091"
  api: ":1318"
  frontend: ":8081"
  dev-ui: ":12346"

@toschdev toschdev requested a review from fadeev March 15, 2021 08:13
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tosch110 before we merge, we need to move IBC Hello world from the "Legacy" section.

@toschdev toschdev merged commit 35e6a4b into master Mar 16, 2021
@toschdev toschdev deleted the hello-world-tutorial branch March 16, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants