- 
                Notifications
    You must be signed in to change notification settings 
- Fork 396
Add IBC Hello World tutorial #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial. I enjoyed it. I did not run it, for time savings today. Please teach me more about the technology, and I can teach us (and learn together) about how we want the standards and styles to be applied for tutorials. I put a LOT of edits. You can commit the suggestions that you agree with, and let's talk through any questions.
| This is great @barriebyron ! Thanks for all the feedback and bringing in the standards ⭐️ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this tutorial is looking so awesome. The intro bits can probably be tweaked a bit more, I can't envision the entire tutorial yet. YAY well done
| Added comments based on renaming of  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so awesome now!
| Thanks for the review @fadeev | 
| I still think we should use the compact notation for hosts, easier to type: host:
  rpc: ":26659"
  p2p: ":26658"
  prof: ":6061"
  grpc: ":9091"
  api: ":1318"
  frontend: ":8081"
  dev-ui: ":12346" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tosch110 before we merge, we need to move IBC Hello world from the "Legacy" section.
The IBC Hello World tutorial describes packets that are sent via two blockchains with a basic
blogmodule.Thanks for writing Concept and Code @ltacker