Skip to content

Conversation

@Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 19, 2021

closes #1481
closes #1482

What does this MR does?

Create a method to install a specific bandchain version to avoid cosmos-sdk version conflicts.

How to test?

  • Scaffold a chain and run the tests:
$ starport s chain github.com/cosmonaut/test
$ starport s module consuming --ibc
$ starport s band oracleone --module consuming

@Pantani Pantani self-assigned this Aug 19, 2021
@lumtis
Copy link
Contributor

lumtis commented Aug 19, 2021

Nice, that perfectly fixes the issue for me👍

However, this is a problem we have on 0.17.2 so we will have to merge this branch in master as a hotfix and release 0.17.3

That's curious tests on 0.17.2 passed, did Band released the new version just after the release?

@fadeev
Copy link
Contributor

fadeev commented Aug 19, 2021

@Pantani props on making a quick fix 🙌 I'm in favour of releasing v0.17.3.

@Pantani
Copy link
Collaborator Author

Pantani commented Aug 19, 2021

Nice, that perfectly fixes the issue for me👍

However, this is a problem we have on 0.17.2 so we will have to merge this branch in master as a hotfix and release 0.17.3

That's curious tests on 0.17.2 passed, did Band released the new version just after the release?

the version was updated some hours ago, and after it, the new PR's started to fail

@ilgooz ilgooz changed the base branch from develop to master August 19, 2021 07:34
@ilgooz ilgooz force-pushed the fix/bandchain-sdk-version branch from afd1f7b to a6c1948 Compare August 19, 2021 07:36
@ilgooz ilgooz merged commit 09f9b4b into master Aug 19, 2021
@ilgooz ilgooz deleted the fix/bandchain-sdk-version branch August 19, 2021 09:08
ilgooz added a commit that referenced this pull request Aug 19, 2021
fix(hotfix): 0.17.3 (#1486)
@ilgooz ilgooz mentioned this pull request Aug 19, 2021
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
fix(oracle): add a specific bandchain pkg version to avoid cosmos-sdk version conflicts (ignite#1486)
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
fix(hotfix): 0.17.3 (ignite#1486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scaffold a packet or a band fix tests

4 participants