Skip to content

fix(pkg/cosmosfaucet): include requested funds to the rate limit calc #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2021
Merged

fix(pkg/cosmosfaucet): include requested funds to the rate limit calc #1453

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cdef8e2
fix: coinsMax check
clockworkgr Aug 11, 2021
5d18e58
fix: lint errors
clockworkgr Aug 11, 2021
b1b7c88
Update starport/pkg/cosmosfaucet/transfer.go
clockworkgr Aug 12, 2021
f0869bd
Update starport/pkg/cosmosfaucet/transfer.go
clockworkgr Aug 12, 2021
0511490
Update starport/pkg/cosmosfaucet/transfer.go
clockworkgr Aug 12, 2021
ddc8534
chore
ilgooz Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions starport/pkg/cosmosfaucet/transfer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,14 @@ func (f Faucet) Transfer(ctx context.Context, toAccountAddress string, amount ui
return err
}

if f.coinsMax[denom] != 0 && totalSent >= f.coinsMax[denom] {
return fmt.Errorf("account has reached maximum credit allowed per account (%d)", f.coinsMax[denom])
if f.coinsMax[denom] != 0 {
if totalSent >= f.coinsMax[denom] {
return fmt.Errorf("account has reached maximum credit allowed per account (%d)", f.coinsMax[denom])
}

if (totalSent + amount) >= f.coinsMax[denom] {
return fmt.Errorf("account is about to reach maximum credit allowed per account. it can only receive up to (%d) in total", f.coinsMax[denom])
}
}

fromAccount, err := f.runner.ShowAccount(ctx, f.accountName)
Expand Down