fix(pkg/cosmosfaucet): include requested funds to the rate limit calc #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks both total transferred so far and total transferred so far + amount requested against the max credit limit
clockworkgr
requested review from
Pantani,
fadeev,
ilgooz and
lumtis
as code owners
lumtis
reviewed
Aug 11, 2021
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
ilgooz
changed the title
ilgooz
approved these changes
Aug 12, 2021
lumtis
approved these changes
Aug 12, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…ignite#1453) * fix: coinsMax check Checks both total transferred so far and total transferred so far + amount requested against the max credit limit * fix: lint errors * Update starport/pkg/cosmosfaucet/transfer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update starport/pkg/cosmosfaucet/transfer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update starport/pkg/cosmosfaucet/transfer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * chore Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: İlker Göktuğ ÖZTÜRK <ilkergoktugozturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks both total transferred so far and total transferred so far + amount requested against the max credit limit
Fixes: #1452