Skip to content

fix(dockerfile): switch user earlier to mitigate perms issues #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix(dockerfile): switch user earlier to mitigate perms issues #1243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ ENV GOPROXY https://proxy.golang.org
#
FROM base as builder

RUN useradd -ms /bin/bash tendermint
USER tendermint

WORKDIR /starport

# cache dependencies.
Expand All @@ -35,9 +38,6 @@ FROM base

COPY --from=builder /go/bin/starport /usr/bin
Copy link
Member

@ilgooz ilgooz Jun 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about moving them above this line? Because this is the actual image will be used by the end users, and we might migrate the base image to alphine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilgooz I'll try it tonight

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilgooz sorry, there's a lot going on in the attached screenshot, but it seems that the permissions issue persists if I put the USER line there

image

Copy link
Member

@ilgooz ilgooz Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, can we also try setting a chmod with "RUN chmod 744 (or other)" after the "USER" param to see if it'll fix it? Otherwise, we can keep things as before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking it out!


RUN useradd -ms /bin/bash tendermint
USER tendermint

WORKDIR /apps

# see docs for exposed ports:
Expand Down