fix(dockerfile): switch user earlier to mitigate perms issues #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
reviewed
Jun 14, 2021
| # | ||
| FROM base | ||
|
|
||
| COPY --from=builder /go/bin/starport /usr/bin |
There was a problem hiding this comment.
What about moving them above this line? Because this is the actual image will be used by the end users, and we might migrate the base image to alphine.
There was a problem hiding this comment.
@ilgooz I'll try it tonight
There was a problem hiding this comment.
@ilgooz sorry, there's a lot going on in the attached screenshot, but it seems that the permissions issue persists if I put the USER line there
There was a problem hiding this comment.
Oh okay, can we also try setting a chmod with "RUN chmod 744 (or other)" after the "USER" param to see if it'll fix it? Otherwise, we can keep things as before.
ilgooz
approved these changes
Jun 15, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address #1202 by switching users earlier.
Using
starport/cli:latestUsing my build:
