Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Apr 27, 2022

Resolves #216

@t-ober t-ober requested a review from a team April 27, 2022 14:18
@t-ober
Copy link
Contributor Author

t-ober commented Apr 27, 2022

Conversion was done with this adaption

Comment on lines +1 to +2
uuid,capex,cos_phi_rated,cp_characteristic,eta_conv,hub_height,id,opex,rotor_area,s_rated
b70374f3-1feb-45af-8011-1304a532d398,0.0,0.9,"cP:{(0.00,0.00),(1.00,0.00),(2.00,0.12),(3.00,0.29),(4.00,0.40),(5.00,0.43),(6.00,0.46),(7.00,0.48),(8.00,0.49),(9.00,0.50),(10.00,0.49),(11.00,0.42),(12.00,0.35),(13.00,0.29),(14.00,0.23),(15.00,0.19),(16.00,0.15),(17.00,0.13),(18.00,0.11),(19.00,0.09),(20.00,0.08),(21.00,0.07),(22.00,0.06),(23.00,0.05),(24.00,0.05),(25.00,0.04),(26.00,0.04),(27.00,0.03),(28.00,0.02),(29.00,0.01),(30.00,0.01),(31.00,0.00),(32.00,0.00),(33.00,0.00),(34.00,0.00),(35.00,0.00),(36.00,0.00),(37.00,0.00),(38.00,0.00),(39.00,0.00),(40.00,0.00),(41.00,0.00),(42.00,0.00),(43.00,0.00),(44.00,0.00),(45.00,0.00),(46.00,0.00),(47.00,0.00),(48.00,0.00),(49.00,0.00),(50.00,0.00)}",100.0,98.0,EnerconE-82,0.0,5281.02,2222.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like here was some considerable rounding done .. find out why that is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqubegithubprchecks

This comment has been minimized.

@t-ober
Copy link
Contributor Author

t-ober commented Apr 27, 2022

Also: Why is there this big discrepancy between lines removed and lines added ?

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #217 (6711bfa) into dev (c2418ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #217   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files         156      156           
  Lines        5751     5751           
  Branches       79       79           
=======================================
  Hits         4580     4580           
  Misses       1171     1171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2418ef...6711bfa. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (81.60% Estimated after merge)
  • No duplication informationNo duplication information (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@t-ober t-ober marked this pull request as draft July 7, 2022 10:24
@jo-bao
Copy link
Contributor

jo-bao commented Mar 15, 2023

@t-ober I think #424 solved #216 and the problem here (roundings). So can this PR be closed? Or is there something else to be done?

@sebastian-peter
Copy link
Member

Resolved with #424

@sebastian-peter sebastian-peter deleted the to/#216-refresh-sample-grids branch April 12, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vn_simona in SIMONA seems to use deprecated csv file version

4 participants