- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
apply rfc compliance to csv sink #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Codecov Report
 @@            Coverage Diff            @@
##                dev     #583   +/-   ##
=========================================
  Coverage     77.92%   77.93%           
+ Complexity     2150     2149    -1     
=========================================
  Files           275      275           
  Lines          8504     8505    +1     
  Branches        807      807           
=========================================
+ Hits           6627     6628    +1     
- Misses         1484     1486    +2     
+ Partials        393      391    -2     
 Continue to review full report at Codecov. 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny comment here...
| Analysis Details0 IssuesCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel | 
| Looks good to me. In the future, we should provide an integration test to prevent such issues from happening though -> #586 | 
Resolves #582