- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
To/#585 ems data model #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
        
          
                src/test/groovy/edu/ie3/datamodel/models/input/system/EmInputTest.groovy
          
            Show resolved
            Hide resolved
        
      | !test | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Codecov Report
 
 @@             Coverage Diff              @@
##                dev     #591      +/-   ##
============================================
+ Coverage     78.17%   78.27%   +0.09%     
- Complexity     2167     2202      +35     
============================================
  Files           280      284       +4     
  Lines          8499     8620     +121     
  Branches        801      805       +4     
============================================
+ Hits           6644     6747     +103     
- Misses         1464     1480      +16     
- Partials        391      393       +2     
 Continue to review full report at Codecov. 
 | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| !test | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not forget an entry within the Changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks for your work here. Since this is important, I would feel better if someone also could do a review, therefore I just comment.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Analysis Details2 IssuesCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel | 
# Conflicts: # src/main/java/edu/ie3/datamodel/io/processor/Processor.java # src/test/groovy/edu/ie3/test/common/SystemParticipantTestData.groovy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thanks
        
          
                src/test/groovy/edu/ie3/datamodel/models/input/container/SystemParticipantsTest.groovy
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSource.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy
              
                Outdated
          
            Show resolved
            Hide resolved
        
      # Conflicts: # src/main/java/edu/ie3/datamodel/io/processor/input/InputEntityProcessor.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolves #585