address reviewers comments

Author: t-ober

src/main/java/edu/ie3/datamodel/io/source/SystemParticipantSource.java

@@ -391,7 +391,34 @@ Set<HpInput> getHeatPumps(
       Set<HpTypeInput> types,
       Set<ThermalBusInput> thermalBuses);
 
+  /**
+   * Returns a unique set of {@link EmInput} instances.
+   *
+   * <p>This set has to be unique in the sense of object uniqueness but also in the sense of {@link
+   * java.util.UUID} uniqueness of the provided {@link EmInput} which has to be checked manually, as
+   * {@link EmInput#equals(Object)} is NOT restricted on the uuid of {@link EmInput}.
+   *
+   * @return a set of object and uuid unique {@link EmInput} entities
+   */
   Set<EmInput> getEmSystems();
 
+  /**
+   * This set has to be unique in the sense of object uniqueness but also in the sense of {@link
+   * java.util.UUID} uniqueness of the provided {@link EmInput} which has to be checked manually, as
+   * {@link EmInput#equals(Object)} is NOT restricted on the uuid of {@link EmInput}.
+   *
+   * <p>In contrast to {@link #getHeatPumps()} this interface provides the ability to pass in an
+   * already existing set of {@link NodeInput} and {@link OperatorInput} entities, the {@link
+   * EmInput} instances depend on. Doing so, already loaded nodes can be recycled to improve
+   * performance and prevent unnecessary loading operations.
+   *
+   * <p>If something fails during the creation process it's up to the concrete implementation of an
+   * empty set or a set with all entities that has been able to be build is returned.
+   *
+   * @param operators a set of object and uuid unique {@link OperatorInput} that should be used for
+   *     the returning instances
+   * @param nodes a set of object and uuid unique {@link NodeInput} entities
+   * @return a set of object and uuid unique {@link EmInput} entities
+   */
   Set<EmInput> getEmSystems(Set<NodeInput> nodes, Set<OperatorInput> operators);
 }

src/main/java/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSource.java

@@ -741,7 +741,6 @@ private Optional<ChpInputEntityData> buildChpEntityData(
             thermalStorage.get()));
   }
 
-  /** {@inheritDoc} */
   @Override
   public Set<EmInput> getEmSystems() {
     Set<OperatorInput> operators = typeSource.getOperators();

src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy

@@ -140,29 +140,29 @@ class CsvFileSinkTest extends Specification implements TimeSeriesTestData {
 	def "A valid CsvFileSink without 'initFiles' should only persist provided elements correctly but not init all files"() {
 		given:
 		CsvFileSink csvFileSink = new CsvFileSink(testBaseFolderPath,
-				new ProcessorProvider([
-						new ResultEntityProcessor(PvResult),
-						new ResultEntityProcessor(WecResult),
-						new ResultEntityProcessor(EvResult),
-						new ResultEntityProcessor(EvcsResult),
-						new InputEntityProcessor(Transformer2WInput),
-						new InputEntityProcessor(NodeInput),
-						new InputEntityProcessor(EvcsInput),
-						new InputEntityProcessor(Transformer2WTypeInput),
-						new InputEntityProcessor(LineGraphicInput),
-						new InputEntityProcessor(NodeGraphicInput),
-						new InputEntityProcessor(CylindricalStorageInput),
-						new InputEntityProcessor(ThermalHouseInput),
-						new InputEntityProcessor(OperatorInput),
-						new InputEntityProcessor(LineInput),
-						new InputEntityProcessor(ThermalBusInput),
-						new InputEntityProcessor(LineTypeInput),
-						new InputEntityProcessor(LoadInput),
-						new InputEntityProcessor(EmInput)
-				], [] as Map),
-				new FileNamingStrategy(),
-				false,
-				",")
+		new ProcessorProvider([
+			new ResultEntityProcessor(PvResult),
+			new ResultEntityProcessor(WecResult),
+			new ResultEntityProcessor(EvResult),
+			new ResultEntityProcessor(EvcsResult),
+			new InputEntityProcessor(Transformer2WInput),
+			new InputEntityProcessor(NodeInput),
+			new InputEntityProcessor(EvcsInput),
+			new InputEntityProcessor(Transformer2WTypeInput),
+			new InputEntityProcessor(LineGraphicInput),
+			new InputEntityProcessor(NodeGraphicInput),
+			new InputEntityProcessor(CylindricalStorageInput),
+			new InputEntityProcessor(ThermalHouseInput),
+			new InputEntityProcessor(OperatorInput),
+			new InputEntityProcessor(LineInput),
+			new InputEntityProcessor(ThermalBusInput),
+			new InputEntityProcessor(LineTypeInput),
+			new InputEntityProcessor(LoadInput),
+			new InputEntityProcessor(EmInput)
+		], [] as Map),
+		new FileNamingStrategy(),
+		false,
+		",")
 
 		UUID uuid = UUID.fromString("22bea5fc-2cb2-4c61-beb9-b476e0107f52")
 		UUID inputModel = UUID.fromString("22bea5fc-2cb2-4c61-beb9-b476e0107f52")

src/test/groovy/edu/ie3/datamodel/models/input/container/SystemParticipantsTest.groovy

@@ -12,7 +12,20 @@ class SystemParticipantsTest extends Specification {
 
 	def "A valid collection of asset entities can be used to build a valid instance of SystemParticipants"() {
 		given:
-		def systemParticipants = SystemParticipantTestData.emptySystemParticipants
+		def systemParticipants = new SystemParticipants(
+			Collections.singleton(SystemParticipantTestData.bmInput),
+			Collections.singleton(SystemParticipantTestData.chpInput),
+			Collections.emptySet(),
+			Collections.singleton(SystemParticipantTestData.evInput),
+			Collections.singleton(SystemParticipantTestData.fixedFeedInInput),
+			Collections.singleton(SystemParticipantTestData.hpInput),
+			Collections.singleton(SystemParticipantTestData.loadInput),
+			Collections.singleton(SystemParticipantTestData.pvInput),
+			Collections.singleton(SystemParticipantTestData.storageInput),
+			Collections.singleton(SystemParticipantTestData.wecInput),
+			Collections.singleton(SystemParticipantTestData.emInput)
+		)
+
 		when:
 		def newlyCreatedSystemParticipants = new SystemParticipants(systemParticipants.allEntitiesAsList())
 

src/test/groovy/edu/ie3/test/common/SampleJointGrid.groovy

@@ -67,20 +67,20 @@ class SampleJointGrid extends SystemParticipantTestData {
 		final PvInput pvInput =
 				new PvInput(
 				UUID.fromString("d56f15b7-8293-4b98-b5bd-58f6273ce229"),
-				"test_pvInput",
-						operator,
-						operationTime,
+			"test_pvInput",
+				operator,
+				operationTime,
 				participantNode,
-						cosPhiFixed,
-						albedo,
-						azimuth,
-						etaConv,
-						elevationAngle,
-						kG,
-						kT,
-				false,
-						sRated,
-						cosPhiRated)
+				cosPhiFixed,
+				albedo,
+				azimuth,
+				etaConv,
+				elevationAngle,
+				kG,
+				kT,
+		false,
+				sRated,
+				cosPhiRated)
 
 		// Load
 		final LoadInput loadInput =