Skip to content

Consider switches in sub grid topology #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 17, 2020

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Aug 13, 2020

Closes #179

@ckittl ckittl added the bug Something isn't working label Aug 13, 2020
@ckittl ckittl added this to the Version 1.0.1 milestone Aug 13, 2020
@ckittl ckittl self-assigned this Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #185 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
- Coverage     76.72%   76.72%   -0.01%     
- Complexity     1548     1559      +11     
============================================
  Files           206      207       +1     
  Lines          6114     6191      +77     
  Branches        586      592       +6     
============================================
+ Hits           4691     4750      +59     
- Misses         1075     1090      +15     
- Partials        348      351       +3     
Impacted Files Coverage Δ Complexity Δ
...n/java/edu/ie3/datamodel/utils/ContainerUtils.java 82.48% <0.00%> (-0.97%) 58.00% <0.00%> (+9.00%) ⬇️
...du/ie3/datamodel/exceptions/TopologyException.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../java/edu/ie3/datamodel/utils/ValidationUtils.java 55.14% <0.00%> (+2.17%) 36.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2031491...9a3c231. Read the comment docs.

@ckittl ckittl marked this pull request as ready for review August 14, 2020 11:02
@ckittl ckittl requested a review from sensarmad August 14, 2020 11:02
…titute/powersystemdatamodel into ck/#197-switches-at-transformers
@ckittl ckittl marked this pull request as draft August 17, 2020 09:33
@ckittl ckittl marked this pull request as ready for review August 17, 2020 13:38
@ckittl ckittl merged commit 1c124dd into master Aug 17, 2020
@ckittl ckittl deleted the ck/#197-switches-at-transformers branch August 17, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tighten scope of SubGridContainer
3 participants